Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS windowtext color is not correctly recognized by CKEDITOR.tools.style.parse functions #2923

Open
jacekbogdanski opened this issue Mar 4, 2019 · 2 comments
Open

CSS windowtext color is not correctly recognized by CKEDITOR.tools.style.parse functions #2923

jacekbogdanski opened this issue Mar 4, 2019 · 2 comments
Labels
status:confirmed An issue confirmed by the development team. type:bug A bug.

Comments

@jacekbogdanski
Copy link
Member

Type of report

Bug

Provide detailed reproduction steps (if any)

CKEDITOR.tools.parse.style functions based on private _findColor function are bugged thus windowtext is not listed as a valid color.

  1. Open CKEditor sample.
  2. Open console.
  3. Copy&pase into console:
CKEDITOR.tools.style.parse.background( 'windowtext' );

Expected result

{ color: 'windowtext' }

Actual result

{ unprocessed: 'windowtext' }

Other details

  • CKEditor version: 4.11.3
@jacekbogdanski jacekbogdanski added type:bug A bug. status:confirmed An issue confirmed by the development team. labels Mar 4, 2019
@jacekbogdanski jacekbogdanski mentioned this issue Mar 4, 2019
Merged
2 tasks
jacekbogdanski added a commit that referenced this issue Mar 4, 2019
@jacekbogdanski
Added changelog entry for #2923, updated tests.
7c06ee9
jacekbogdanski added a commit that referenced this issue Mar 4, 2019
@jacekbogdanski
Added changelog entry for #2923, updated tests.
830f4d9
@f1ames
Copy link
Contributor

f1ames commented Mar 5, 2019

Probably it also concerns other system colors as well.

Comandeer pushed a commit that referenced this issue Apr 29, 2019
@jacekbogdanski @Comandeer
Added changelog entry for #2923, updated tests.
e76b664
@jacekbogdanski jacekbogdanski mentioned this issue May 17, 2019
Open
@jacekbogdanski
Copy link
Member Author

The issue should be fixed by #3112 improvement.

Comandeer pushed a commit that referenced this issue Jun 3, 2019
@jacekbogdanski @Comandeer
Added changelog entry for #2923, updated tests.
4196177
@Reinmar Reinmar mentioned this issue Aug 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@f1ames @jacekbogdanski