Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safari incorrectly removes blocks after selecting all #3705

Closed
Comandeer opened this issue Dec 3, 2019 · 2 comments · Fixed by #3725
Closed

Safari incorrectly removes blocks after selecting all #3705

Comandeer opened this issue Dec 3, 2019 · 2 comments · Fixed by #3725
Assignees
@Dumluregn
Labels
browser:safari The issue can only be reproduced in the Safari browser. core The issue is caused by the editor core code. regression This issue is a regression. status:confirmed An issue confirmed by the development team. type:bug A bug.
Milestone
Iteration 2019-1 ...

Comments

@Comandeer
Copy link
Member

Type of report

Bug

Provide detailed reproduction steps (if any)

  1. Open https://jsfiddle.net/Comandeer/jnf5at6z/
  2. Open console.
  3. Click "Extract HTML" button.

Expected result

<p><br></p> is logged.

Actual result

<div><br></div><p><br></p> is logged.

Other details

It seems that Safari, instead of just deleting both blocks, removes their content and preserves blocks.

  • Browser: Safar
  • OS: macOS
  • CKEditor version: 4.13.0
@Comandeer Comandeer added type:bug A bug. status:confirmed An issue confirmed by the development team. browser:safari The issue can only be reproduced in the Safari browser. regression This issue is a regression. core The issue is caused by the editor core code. labels Dec 3, 2019
@Comandeer Comandeer mentioned this issue Dec 3, 2019
Closed
2 tasks
@f1ames
Copy link
Contributor

f1ames commented Dec 3, 2019

Breaking commit 06b94a6.

@f1ames
Copy link
Contributor

f1ames commented Dec 3, 2019

It looks like (from review) that this change could be only applied to FF browser - #3213 (comment):

Firefox cases

It looks like adding skipBogus = true to call on range.shrink solved the issue.

However, it should be carefully investigated.

@f1ames f1ames added this to the Next milestone Dec 4, 2019
@f1ames f1ames mentioned this issue Dec 4, 2019
Open
@Dumluregn Dumluregn self-assigned this Dec 4, 2019
@Dumluregn Dumluregn mentioned this issue Dec 10, 2019
Merged
2 tasks
@f1ames f1ames modified the milestones: Next, Iteration 2019-1 Dec 10, 2019
This was referenced Aug 20, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dumluregn Dumluregn

Labels
browser:safari The issue can only be reproduced in the Safari browser. core The issue is caused by the editor core code. regression This issue is a regression. status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
Milestone
Iteration 2019-1 (4.14.0)
Development

Successfully merging a pull request may close this issue.

Fix for: Safari incorrectly removes blocks after selecting all ckeditor/ckeditor4
3 participants
@f1ames @Comandeer @Dumluregn