Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error thrown when dragging and dropping only the first inserted widget #3926

Closed
spacevoyager78 opened this issue Mar 12, 2020 · 2 comments · Fixed by #4045
Closed

Error thrown when dragging and dropping only the first inserted widget #3926

spacevoyager78 opened this issue Mar 12, 2020 · 2 comments · Fixed by #4045
Assignees
Labels
plugin:widget The plugin which probably causes the issue. regression This issue is a regression. status:confirmed An issue confirmed by the development team. type:bug A bug.
Milestone

Comments

@spacevoyager78
Copy link

Type of report

Bug

Provide detailed reproduction steps (if any)

  1. Go to https://jsfiddle.net/pwfjv6xs/
  2. Insert at least one simplebox widgets by clicking "Insert Widget" button above CKEditor or by clicking the button with no icon right next to the Image button.
  3. Try to drag and drop the first inserted widget.

Expected result

Drag and drop should work.

Actual result

An error is thrown for the first widget only. The next ones can be dragged and dropped.
If I click Source button twice, the first widget can finally be dragged and dropped.

  • Browser: Firefox, Chrome
  • OS: Windows 7 SP1 64bit
  • CKEditor version: 4.14.0
  • Installed CKEditor plugins: Full
@spacevoyager78 spacevoyager78 added the type:bug A bug. label Mar 12, 2020
@Comandeer Comandeer added the status:confirmed An issue confirmed by the development team. label Mar 12, 2020
@NogaMan
Copy link

NogaMan commented Apr 3, 2020

I have fixed it locally already by changing the widget plugin code.
I have the full preset, so widget plugin was embedded in ckeditor.js.
I assume that with lower presets it may not be embedded and would be stored separately in plugins/widget/plugin.js instead.

The details of the change are in the commit here in my fork NogaMan@d4375ba.
I am too lazy to write tests to open PR here.

@jacekbogdanski jacekbogdanski self-assigned this May 11, 2020
@jacekbogdanski jacekbogdanski added plugin:widget The plugin which probably causes the issue. workload:low labels May 11, 2020
@jacekbogdanski jacekbogdanski added the regression This issue is a regression. label May 11, 2020
@Dumluregn
Copy link
Contributor

Closed via #4045.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin:widget The plugin which probably causes the issue. regression This issue is a regression. status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants