Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced image plugin drag and drop broken in 4.14.0 #3953

Closed
mikemunger opened this issue Mar 25, 2020 · 6 comments
Closed

Enhanced image plugin drag and drop broken in 4.14.0 #3953

mikemunger opened this issue Mar 25, 2020 · 6 comments
Assignees
Labels
plugin:clipboard The plugin which probably causes the issue. regression This issue is a regression. status:confirmed An issue confirmed by the development team. type:bug A bug.

Comments

@mikemunger
Copy link

I'm not sure about other versions, but in ckeditor 4.14.0 drag and drop to reposition an image using enhanced image plugin is broken, including on the demo page here:

https://ckeditor.com/docs/ckeditor4/latest/examples/image2.html

I checked in the latest firefox and chrome on ubuntu 18.04 linux.

Steps to reproduce:

This will produce error output in the js console, and will not reposition the image as expected.

Error output in chrome after drag and drop of enhance image in editor:
ckeditor.js:716 Uncaught TypeError: Cannot read property 'endContainer' of undefined
at Object.isDropRangeAffectedByDragRange (ckeditor.js:716)
at Object.internalDrop (ckeditor.js:717)
at ckeditor.js:706

@f1ames
Copy link
Contributor

f1ames commented Mar 26, 2020

Thanks for reporting @mikemunger!

You can always check with the previous docs version, e.g. https://ckeditor.com/docs/ckeditor4/4.13.1/examples/image2.html. I already did and it works there correctly which means this is a recent regression in 4.14 version 😞

@f1ames f1ames added plugin:clipboard The plugin which probably causes the issue. regression This issue is a regression. status:confirmed An issue confirmed by the development team. type:bug A bug. labels Mar 26, 2020
@Dumluregn
Copy link
Contributor

May be connected with #3875.

@spacevoyager78
Copy link

spacevoyager78 commented Mar 26, 2020

It could be connected to #3926 because in the image2 demo if you copy the image and paste it, the new one can be dragged, the first one can't be dragged, so it could be a regression in widget plugin, not image2.

@NogaMan
Copy link

NogaMan commented Apr 3, 2020

It is connected to #3926.
Check out my comment for fix #3926 (comment)

@jacekbogdanski
Copy link
Member

The issue has been introduced in 613f7a8

@jacekbogdanski
Copy link
Member

Duplicate of #3926

@jacekbogdanski jacekbogdanski marked this as a duplicate of #3926 May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin:clipboard The plugin which probably causes the issue. regression This issue is a regression. status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
Development

No branches or pull requests

6 participants