ckEditor editor.js leaking 'load' eventListener attached to the window object

[rohit1]

Type of report

in ckEditor_base, we register 'load' event listener to window object, but never remove it

See below -

ckeditor4/core/ckeditor_base.js

Line 234 in 8fccb33

if ( document.addEventListener ) {

window.addEventListener( 'load', onReady, false );

if you see in destroy function at removeAllListeners()

ckeditor4/core/editor.js

Line 924 in 8fccb33

this.removeAllListeners();

Probably we should remove this from window object under onReady() function at this try block where we detach others

ckeditor4/core/ckeditor_base.js

Line 202 in 8fccb33

if ( document.addEventListener ) {

document.removeEventListener( 'DOMContentLoaded', onReady, false );

Proposing the fix from this change -
rohit1:rohit1-ckeditor4-load-eventlistener-leak-fix

Raising a PR here for inputs on this proposed solution -
#4272

please advise if this is NOT the right way to fix this:)
thank you

Bug

Provide detailed reproduction steps (if any)

1. …
2. …
3. …

Expected result

What is the expected result of the above steps?

Actual result

What is the actual result of the above steps?

Other details

• Browser: …
• OS: …
• CKEditor version: …
• Installed CKEditor plugins: …

[Comandeer]

Good catch! It seems that we really don't remove that load listener.

[Comandeer]

Merged in 170451 and will be released in CKEditor 4.15.1.