-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rohit1 ckeditor4 load eventlistener leak fix #4272
Rohit1 ckeditor4 load eventlistener leak fix #4272
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contribution @rohit1!
Your pull request is missing tests, see our Contributing Code guide for more details.
I think unit tests would be enough here. If you will have any problems writing them, just feel free to reach out so we can assist or take over this PR.
It's been a while since we last heard from you. We are marking this pull request as stale due to inactivity. Please provide the requested feedback or the pull request will be closed after next 7 days. |
Ok, taking over this PR to add tests. |
7d13d16
to
f753d59
Compare
Rebased and retargeted onto latest |
Unfortunately, changes in ckeditor4/core/ckeditor_base.js Lines 11 to 17 in aa1e0e7
So apart from changes in this file, the changes then needs to be compressed and moved to |
Ok, I have to ignore unit tests on IE8 due to sinon stubbing issue (see this commit cfc5283). Also IE8 is ignored outside of |
All tests in IE8 are also green so I guess nothing exploded 😅 |
cfc5283
to
f13fa4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What is the purpose of this pull request?
Does your PR contain necessary tests?
All patches that change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.
This PR contains
Did you follow the CKEditor 4 code style guide?
Your code should follow the guidelines from the CKEditor 4 code style guide which helps keep the entire codebase consistent.
What is the proposed changelog entry for this pull request?
What changes did you make?
added removeEventListener() in onReady callback function
Which issues does your PR resolve?
Closes #4273.