Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Balloon Toolbar #1275

Merged
merged 251 commits into from
Nov 29, 2017
Merged

Introduce Balloon Toolbar #1275

merged 251 commits into from
Nov 29, 2017

Conversation

f1ames
Copy link
Contributor

@f1ames f1ames commented Nov 29, 2017

What is the purpose of this pull request?

New feature

Does your PR contain necessary tests?

All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.

This PR contains

  • Unit tests
  • Manual tests

What changes did you make?

This code has been already reviewed in smaller parts.

Closes #933.

f1ames and others added 27 commits November 29, 2017 15:56
Move creation API to the editor directly
Balloon Toolbar should prefer bottom position
Ballonpanel toolbar unit test fix for IE/Edge
Decreased balloon toolbar triangle size
Corrected Balloon Toolbar CSS loading unit test for a built version of CKEditor
Balloon toolbar should be repositioned on window resize
Decreased balloon toolbar paddings
@mlewand mlewand self-requested a review November 29, 2017 15:26
Copy link
Contributor

@mlewand mlewand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feature has all we need for the public release. Good work everyone!

@mlewand mlewand merged commit e601270 into major Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants