Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed: Context menu is incorrectly positioned when opened with Shift-F10 #1627

Merged
merged 28 commits into from
Sep 4, 2018
Merged

Fixed: Context menu is incorrectly positioned when opened with Shift-F10 #1627

merged 28 commits into from
Sep 4, 2018

Commits on Sep 4, 2018

  1. Fixed: Context menu is incorrectly positioned when opened with Shift-F10

    @engineering-this @Comandeer
    engineering-this authored and Comandeer committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    e985133 View commit details
    Browse the repository at this point in the history

  2. Added changelog entry

    @engineering-this @Comandeer
    engineering-this authored and Comandeer committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    fa53e07 View commit details
    Browse the repository at this point in the history

  3. Removed unnecessary line

    @engineering-this @Comandeer
    engineering-this authored and Comandeer committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    a2081d2 View commit details
    Browse the repository at this point in the history

  4. Updated version tag, fixed typo

    @engineering-this @Comandeer
    engineering-this authored and Comandeer committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    66890f1 View commit details
    Browse the repository at this point in the history

  5. Adding comment, using our getName method instead of native `tagName… 

    …` property.
    @engineering-this @Comandeer
    engineering-this authored and Comandeer committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    604164d View commit details
    Browse the repository at this point in the history

  6. Added fallback when rectList is empty

    @engineering-this @Comandeer
    engineering-this authored and Comandeer committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    2213faa View commit details
    Browse the repository at this point in the history

  7. Moved logic on contextmenu positioning with keystrokes from floatpane… 

    …l plugin to contextmenu
    @engineering-this @Comandeer
    engineering-this authored and Comandeer committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    6c36815 View commit details
    Browse the repository at this point in the history

  8. Moved tests to correct plugin

    @engineering-this @Comandeer
    engineering-this authored and Comandeer committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    57b67d1 View commit details
    Browse the repository at this point in the history

  9. Removed check from contextMenu command

    @engineering-this @Comandeer
    engineering-this authored and Comandeer committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    56e4af7 View commit details
    Browse the repository at this point in the history

  10. Added unit test

    @engineering-this @Comandeer
    engineering-this authored and Comandeer committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    7eb4dd9 View commit details
    Browse the repository at this point in the history

  11. Added comment

    @engineering-this @Comandeer
    engineering-this authored and Comandeer committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    4111707 View commit details
    Browse the repository at this point in the history

  12. Changed test name

    @engineering-this @Comandeer
    engineering-this authored and Comandeer committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    4978dec View commit details
    Browse the repository at this point in the history

  13. Moved assertions to resume callback

    @engineering-this @Comandeer
    engineering-this authored and Comandeer committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    a4a2a8e View commit details
    Browse the repository at this point in the history

  14. Updated version tag

    @engineering-this @Comandeer
    engineering-this authored and Comandeer committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    c7a8ec5 View commit details
    Browse the repository at this point in the history

  15. Context menu opened by keystroke will be positioned in relation to la… 

    …st selected range
    @engineering-this @Comandeer
    engineering-this authored and Comandeer committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    36a75a4 View commit details
    Browse the repository at this point in the history

  16. Context menu opened with keystroke will be positioned on left side of… 

    … selected element in rtl editors
    @engineering-this @Comandeer
    engineering-this authored and Comandeer committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    9e1eef0 View commit details
    Browse the repository at this point in the history

  17. Added table and tableselection plugins to test, changed editor ids

    @engineering-this @Comandeer
    engineering-this authored and Comandeer committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    d87f96e View commit details
    Browse the repository at this point in the history

  18. Fixing comments

    @engineering-this @Comandeer
    engineering-this authored and Comandeer committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    86a66e8 View commit details
    Browse the repository at this point in the history

  19. Fixed test failing in dashboard

    @engineering-this @Comandeer
    engineering-this authored and Comandeer committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    e0702c7 View commit details
    Browse the repository at this point in the history

  20. Added dir=rtl attribute to inline editor

    @engineering-this @Comandeer
    engineering-this authored and Comandeer committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    0ac283c View commit details
    Browse the repository at this point in the history

  21. Fixed test

    @engineering-this @Comandeer
    engineering-this authored and Comandeer committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    078e7b3 View commit details
    Browse the repository at this point in the history

  22. Fixed wrong position of context menu when for scrolled inline editors

    @engineering-this @Comandeer
    engineering-this authored and Comandeer committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    c5a7b25 View commit details
    Browse the repository at this point in the history

  23. Added brs to required page scroll

    @engineering-this @Comandeer
    engineering-this authored and Comandeer committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    915aa83 View commit details
    Browse the repository at this point in the history

  24. Added test step

    @engineering-this @Comandeer
    engineering-this authored and Comandeer committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    3c1b45e View commit details
    Browse the repository at this point in the history

  25. Comment regarding wrong position of context menu in IE8

    @engineering-this @Comandeer
    engineering-this authored and Comandeer committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    c77ac0e View commit details
    Browse the repository at this point in the history

  26. Update manual test.

    @Comandeer
    Comandeer committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    ed2709f View commit details
    Browse the repository at this point in the history

  27. Simplified test, now it is stable

    @engineering-this @Comandeer
    engineering-this authored and Comandeer committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    cb0e2d1 View commit details
    Browse the repository at this point in the history

  28. Updated version tag

    @engineering-this @Comandeer
    engineering-this authored and Comandeer committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    9bce709 View commit details
    Browse the repository at this point in the history