Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduced mentions plugin #1757

Merged
merged 90 commits into from
Apr 25, 2018
Merged

Introduced mentions plugin #1757

merged 90 commits into from
Apr 25, 2018

Conversation

jacekbogdanski
Copy link
Member

@jacekbogdanski jacekbogdanski commented Mar 7, 2018 •
edited
Loading

What is the purpose of this pull request?

New feature

Does your PR contain necessary tests?

All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.

This PR contains

  • Unit tests
  • Manual tests

What changes did you make?

Introduced mentions plugin.

Based on #1727

@mlewand mlewand closed this Mar 16, 2018
@mlewand mlewand changed the base branch from next to major March 16, 2018 10:15
@mlewand
Copy link
Contributor

mlewand commented Mar 16, 2018

Sorry, I've removed the next branch before rebasing all the PRs that were based on it. This PR is now rebased onto latest major (4.10.0).

@mlewand mlewand reopened this Mar 16, 2018
@mlewand mlewand self-requested a review April 17, 2018 14:43
@jacekbogdanski
Introduced Autocomplete plugin.
15ce5b3
@jacekbogdanski
Added unit tests for text watcher plugin.
23ba1b0
@jacekbogdanski
Added unit tests for range.getClientPosition function.
e1d062f
@jacekbogdanski
Added manual tests for caretposition.
1fbd814
@jacekbogdanski
Added autocomplete model tests and fixed minor bugs.
5dad27d
@jacekbogdanski
Added default styles to autocomplete.
fd9b5fa
@jacekbogdanski
Added destroy methods.
914c1ea
@jacekbogdanski
Added autocomplete tests.
cd3636f
@jacekbogdanski
Fixed bug causing autocompletition on mouse click.
a2ae13a
@jacekbogdanski
Added docs to listeners and refactored to keep it consistent.
9164224
@jacekbogdanski
Fixed toolbar positioning on scroll.
ed4931a
@jacekbogdanski
Minor comment change.
e8ced8d
@jacekbogdanski
Removed watching text on focus.
161b557
@jacekbogdanski
Updated unit tests for autocomplete view.
c9e855e
@jacekbogdanski
Added manual test template.
ccb8fea
@jacekbogdanski
Changed samples.
93f8058
@jacekbogdanski
Updated license headers.
08be5a1
@jacekbogdanski
Fixed invalid license url in headers.
6afd010
@jacekbogdanski
Removed invalid license header.
2dd9a0c
@jacekbogdanski
Created Mentions plugin.
339f919
@jacekbogdanski
Added unit tests to mentions plugin.
686927f
@jacekbogdanski
Refactored unit tests.
49c4b81
@jacekbogdanski
Added configuration test.
5f2bb1a
@jacekbogdanski
Refactored mentions.
91d01f9
@jacekbogdanski
Added docs.
f06e33d
jacekbogdanski and others added 22 commits April 25, 2018 11:02
@jacekbogdanski
Small test change.
568a19d
@mlewand @jacekbogdanski
Tests: simplified fixtures markup.
20d0582
@jacekbogdanski
Refactored tests.
d1490f3
@jacekbogdanski
Ignored tests for ie8.
94c34c7
@mlewand @jacekbogdanski
Removed fixed an issue where margin in parents would result in broken…
da81276 
… autocomplete position.
@jacekbogdanski
Fixed view positioning relative to the host element.
ed25deb
@jacekbogdanski
Refactored tests.
c547e09
@jacekbogdanski
Fixed getCaretRect tests.
0f66871
@jacekbogdanski
Added unit tests for view.getCaretRect.
1542c0e
@jacekbogdanski
Typo fix.
efb080d
@jacekbogdanski
Fixed tests for IE9.
81d14ab
@mlewand @jacekbogdanski
Tests: autocomplete positioning changed TC name, and adjusted comment.
a25c806
@jacekbogdanski
Fixed view positioning for bottom edge.
1b889ba
@jacekbogdanski
Fixed edge positioning for caret height.
479e4e9
@jacekbogdanski
Added inline tests.
a0bfb19
@jacekbogdanski
Moved view positioning tests into separate file.
db23436
@jacekbogdanski
Docs: added since tag and refactored code samples.
01122ca
@mlewand
Tests: ignore autocomplete positioning tests on IE8.
92e85c9
@mlewand
Merge pull request #1732 from ckeditor/t/1703-3559
dc9fc70 
Fixed autocomplete view positioning
@jacekbogdanski
Renamed panelActive into active.
e639825
@jacekbogdanski
Refactored model tests.
2b26125
@jacekbogdanski
Merge branch 't/1703' of github.com:ckeditor/ckeditor-dev into t/1703
79eb58f
@jacekbogdanski jacekbogdanski changed the base branch from major to t/1751 April 25, 2018 10:31
@jacekbogdanski
Copy link
Member Author

jacekbogdanski commented Apr 25, 2018 •
edited
Loading

As @mlewand already mentioned #1757 (comment) we want to split this PR into two different plugins:

To do this I already created t/1751 target branch for this PR which will act as a base branch for autocomplete plugin. I also removed mentions plugin from this PR to keep it clean. mentions plugin will be restored with t/1703-b branch based on autocomplete plugin (t/1751) by removing 2451cf6 commit and its revert.

With this changes, we will separate autocomplete and mentions plugins.

@jacekbogdanski jacekbogdanski merged commit ca1a82f into t/1751 Apr 25, 2018
This was referenced Apr 25, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlewand mlewand mlewand requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacekbogdanski @mlewand