Set toolbarconfigurator button "type" attribute #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reinmar
added a commit
that referenced
this pull request
Jul 27, 2015
Set toolbarconfigurator button "type" attribute to avoid form submission.
|
Thanks! :) We're glad people like it and that it's also helpful for other projects. |
|
Changelog entry in a4c9294. |
|
Thanks for the merge @Reinmar. For my future reference is submitting a PR like this the right way to send in fixes or should I open an issue instead? |
|
This one was ok to be closed this way, because it was not related to the editor itself, but samples and it was a simple thing. But in >99% cases we would need a ticket on http://dev.ckeditor.com, although, if a PR is clear for us (it includes a proper description), we can open that ticket ourselves. Not a big deal. You can find more details about contributing code in docs.ckeditor.com/#!/guide/dev_contributing_code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Love the new configurator! I've had good success integrating it with our php-based CRM to allow users to configure their editing experience in-app. One little problem was that the missing "type" attribute on the buttons would cause premature form submission. Thanks for considering this change.