Fixed Ctrl+A focusing inline editor if it was started and ended with a list #2274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlewand
added
the
review:easy
jacekbogdanski
requested changes
Aug 1, 2018
| editable = editor.editable(); | ||
|
|
||
| editable.attachListener( doc, 'keydown', function( evt ) { | ||
| editable.attachListener( editable, 'keydown', function( evt ) { |
There was a problem hiding this comment.
I would be nice to provide some simple explanation comment with the issue ticket reference for this change.
There was a problem hiding this comment.
TBH I don't think it is needed there, it's fairly logical that ctrl/cmd+a should be catched from within the editable. It's actually shame that we didn't catch this earlier, because in fact it didn't make sense in case of inline editors. 🙂
| @@ -4,12 +4,36 @@ | |||
| ( function() { | |||
| 'use strict'; | |||
|
|
|||
| bender.editor = true; | |||
| bender.editors = { | |||
| editor1: { | |||
There was a problem hiding this comment.
The name doesn't tell much. Maybe classic?
There was a problem hiding this comment.
Addressed in 84265bd.
| editor1: { | ||
| creator: 'replace' | ||
| }, | ||
| editor2: { |
There was a problem hiding this comment.
Addressed in 84265bd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Bug fix
Does your PR contain necessary tests?
All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.
This PR contains
What changes did you make?
The issue is described here: #1773 (comment)
I had to adjust the initial pull request as commented above. Also tests were added.
Follow-up of #1773.
Closes #1719.