Fixed emoji text matching with repeated symbols in a single line #2452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlewand
reviewed
Oct 3, 2018
tests/plugins/emoji/basic.js
Outdated
| @@ -31,6 +31,12 @@ | |||
|
|
|||
| var stub = null; | |||
|
|
|||
| // Disable autocomplete throttling so the tests can be run synchronously. | |||
| var throttle = CKEDITOR.tools.buffers.throttle; | |||
There was a problem hiding this comment.
If possible try to merge subsequent var statements.
tests/plugins/emoji/basic.js
Outdated
| wait(); | ||
| bot.setHtmlWithSelection( '<p>foo :collision :collision^</p>' ); | ||
| editor.editable().fire( 'keyup', new CKEDITOR.dom.event( {} ) ); | ||
| assert.areSame( ':collision', autocomplete.model.query, 'Model keeps wrong querry.' ); |
There was a problem hiding this comment.
There should be no dots at the end of assert msg. I can see that you might have take it from other asserts in this suite.
What's interesting is that objectAsserts have correct form 🙂
| <h2>Classic editor</h2> | ||
| <div id="classic"></div> | ||
| <h2>Inline editor</h2> | ||
| <div id="inline" contenteditable="true"> |
There was a problem hiding this comment.
Just a detail, but since you're closing all of the tags in a single line, it would be nice to close this one as well.
mlewand
approved these changes
Oct 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Bug fix
Does your PR contain necessary tests?
All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.
This PR contains
What changes did you make?
Emoji symbol was incorrectly matched when tested text have duplicated symbols.
Closes #2394