Add CKEDITOR.dom.documentFragment.find and CKEDITOR.dom.documentFragment.findOne #2701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlewand
suggested changes
Dec 28, 2018
CHANGES.md
Outdated
| @@ -6,7 +6,7 @@ | |||
| API Changes: | |||
|
|
|||
| * [#1496](https://github.com/ckeditor/ckeditor-dev/issues/1496): [Balloon Toolbar](https://ckeditor.com/cke4/addon/balloontoolbar) exposed methods [CKEDITOR.ui.balloonToolbar.repositon](https://ckeditor.com/docs/ckeditor4/latest/api/CKEDITOR_ui_balloonToolbar.html#reposition) and [CKEDITOR.ui.balloonToolbarView.reposition](https://ckeditor.com/docs/ckeditor4/latest/api/CKEDITOR_ui_balloonToolbarView.html#reposition). | |||
|
|
|||
| * [#2021]: Add [`CKEDITOR.dom.documentFragment.find`](https://ckeditor.com/docs/ckeditor4/latest/api/CKEDITOR_dom_documentFragment.html#find) and [`CKEDITOR.dom.documentFragment.findOne`](https://ckeditor.com/docs/ckeditor4/latest/api/CKEDITOR_dom_documentFragment.html#findOne) methods. | |||
There was a problem hiding this comment.
I don't think the links are valid, they should be prefixed with method- string, like this example:
https://ckeditor.com/docs/ckeditor4/latest/api/CKEDITOR_dom_documentFragment.html#method-append
tests/core/dom/documentfragment.js
Outdated
| found = frag.find( 'b' ); | ||
| assert.areEqual( 2, found.count() ); | ||
| assert.isTrue( b1.equals( found.getItem( 0 ) ) ); | ||
| assert.isTrue( b2.equals( found.getItem( 1 ) ) ); |
There was a problem hiding this comment.
There are no fail messages for 2 identically reported (if failed) assertions.
There was a problem hiding this comment.
Remember that we have this customization of assert.areEqual that works with our DOM wrappers too.
assert.areEqual( b2, found.getItem( 1 ), 'Item #1' );
tests/core/dom/documentfragment.js
Outdated
| frag.append( em ); | ||
|
|
||
| found = frag.findOne( 'b' ); | ||
| assert.isTrue( b1.equals( found ) ); |
There was a problem hiding this comment.
While found var makes perfect sense for the previous case, it is not needed here.
It could be just simplified down to
assert.areEqual( b1, frag.findOne( 'b' ) );Just a single line instead of three.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
New feature
Does your PR contain necessary tests?
All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.
This PR contains
What changes did you make?
I've added
findandfindOnemethods to theCKEDITOR.dom.documentFragment.Closes #2021.