Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CKEDITOR.tools.array.some method #3155

Merged
merged 7 commits into from
Jul 12, 2019
Merged

Add CKEDITOR.tools.array.some method #3155

merged 7 commits into from
Jul 12, 2019

Conversation

Comandeer
Copy link
Member

What is the purpose of this pull request?

New feature

Does your PR contain necessary tests?

All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.

This PR contains

  • Unit tests
  • Manual tests

What changes did you make?

This PR introduces CKEDITOR.tools.array.some method. Alongside this change I slightly enhanced existing API docs and tests.

Closes #3154.

@f1ames
Copy link
Contributor

f1ames commented Jul 3, 2019

Rebased on the latest major.

Copy link
Contributor

@f1ames f1ames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just two details to cover.

core/tools.js Outdated Show resolved Hide resolved
core/tools.js Outdated Show resolved Hide resolved
@Comandeer Comandeer self-assigned this Jul 11, 2019
@Comandeer
Copy link
Member Author

Fixed and rebased onto latest major.

@Comandeer Comandeer requested a review from f1ames July 11, 2019 13:35
@f1ames f1ames self-assigned this Jul 12, 2019
Copy link
Contributor

@f1ames f1ames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@f1ames f1ames merged commit e59d465 into major Jul 12, 2019
@CKEditorBot CKEditorBot deleted the t/3154 branch July 12, 2019 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CKEDITOR.tools.array.some method
2 participants