Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace arguments.callee with named function expression #331

Closed
wants to merge 10 commits into from

Conversation

IgorRubinovich
Copy link
Contributor

@IgorRubinovich IgorRubinovich commented Mar 24, 2017

This is a trivial change that prevents the colorbutton plugin from breaking when deployed as part of a browserify bundle. Namely Chrome throws:

account.html:22179` Uncaught TypeError: 'caller', 'callee', and 'arguments' properties may not be accessed on strict mode functions or the arguments objects for calls to them

Since ES5 when in strict mode the deprecated arguments.callee is explicitly forbidden.

Unless there's a very good reason I can't see from inspecting just this code to keep using arguments.callee this is the recommended way.

@Comandeer Comandeer changed the base branch from master to major March 27, 2017 09:19
@Comandeer
Copy link
Member

Thx @IgorRubinovich for this fix! It was merged to CKEditor 4 with fb5e3a3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants