Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken paste of plain text in firefox #3525

Merged
merged 5 commits into from
Oct 2, 2019
Merged

Fix broken paste of plain text in firefox #3525

merged 5 commits into from
Oct 2, 2019

Conversation

msamsel
Copy link
Contributor

@msamsel msamsel commented Oct 2, 2019

What is the purpose of this pull request?

Bug fix

Does your PR contain necessary tests?

All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.

This PR contains

  • Unit tests
  • Manual tests

What is the proposed changelog entry for this pull request?

* [#3475](https://github.com/ckeditor/ckeditor4/issues/3475) [Firefox] Fix: broken paste of plain text.

What changes did you make?

  • Correct comparison expression to use correct data types.

Closes: #3475

@f1ames f1ames self-requested a review October 2, 2019 11:49
@f1ames f1ames self-assigned this Oct 2, 2019
Copy link
Contributor

@f1ames f1ames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I have simplified manual test a little and tagged another manual test created for initial case for which this code was introduced. (see 7d48379).

@f1ames f1ames merged commit 7d48d2b into master Oct 2, 2019
@CKEditorBot CKEditorBot deleted the t/3475 branch October 2, 2019 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants