Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add preserving custom colors feature #3784

Merged
merged 162 commits into from
Jul 9, 2020
Merged

Add preserving custom colors feature #3784

merged 162 commits into from
Jul 9, 2020

Commits on Jul 9, 2020

  1. Add features described in issue.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    dbe9c69 View commit details
    Browse the repository at this point in the history

  2. Add manual test for finding content colors.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    5f39387 View commit details
    Browse the repository at this point in the history

  3. Add manual test for preserving custom colors.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    ad0b6f2 View commit details
    Browse the repository at this point in the history

  4. Swap sections.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    0cf9afa View commit details
    Browse the repository at this point in the history

  5. Remove excessive color tile before reassigning aria attributes.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    d8c124a View commit details
    Browse the repository at this point in the history

  6. Refactor removing excessive color tile.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    de79c97 View commit details
    Browse the repository at this point in the history

  7. Add consistency in style for adding table elements.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    13129ed View commit details
    Browse the repository at this point in the history

  8. Small refactor 'onOpen' for panels.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    2bf722c View commit details
    Browse the repository at this point in the history

  9. Use color label if it's available.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    fd5dfff View commit details
    Browse the repository at this point in the history

  10. Update manual tests according to change in color labels.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    65cafa9 View commit details
    Browse the repository at this point in the history

  11. Add unit tests for content colors.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    2c4658d View commit details
    Browse the repository at this point in the history

  12. Add first unit tests for preserving custom colors.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    dcfda14 View commit details
    Browse the repository at this point in the history

  13. Add async tests for custom colors.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    71305d4 View commit details
    Browse the repository at this point in the history

  14. Refactor unit tests.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    830d8b5 View commit details
    Browse the repository at this point in the history

  15. More tests refactoring.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    2eb0707 View commit details
    Browse the repository at this point in the history

  16. Add proper tags to unit tests.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    2b3f2b1 View commit details
    Browse the repository at this point in the history

  17. Make some small changes in manual tests.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    7e83919 View commit details
    Browse the repository at this point in the history

  18. Add comment.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    c7085b2 View commit details
    Browse the repository at this point in the history

  19. Fix typo.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    1ce62b8 View commit details
    Browse the repository at this point in the history

  20. Make colors chosen from default palette appear in custom colors too.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    de16fa6 View commit details
    Browse the repository at this point in the history

  21. Merge custom and content colors into one row.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    a77212c View commit details
    Browse the repository at this point in the history

  22. Run content search only onBlock instead of onOpen.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    71d87d8 View commit details
    Browse the repository at this point in the history

  23. Unify naming from custom and content colors to just colorHistory.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    8a2ce90 View commit details
    Browse the repository at this point in the history

  24. Fix cssAttribute.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    b07ae99 View commit details
    Browse the repository at this point in the history

  25. Rename cssAttribute->cssProperty.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    f8ed326 View commit details
    Browse the repository at this point in the history

  26. Replace custom panel id logic with dedicated one.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    2369ef4 View commit details
    Browse the repository at this point in the history

  27. Replace row label with horizontal rule and extract html to generators.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    0998b39 View commit details
    Browse the repository at this point in the history

  28. Remove unnecessary variable.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    1a2ac6d View commit details
    Browse the repository at this point in the history

  29. Don't hide separator - it's no longer necessary.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    fee0e7e View commit details
    Browse the repository at this point in the history

  30. Skip removing tiles - there will never be one right now.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    c36791d View commit details
    Browse the repository at this point in the history

  31. Add color names handling for content colors.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    3d10b73 View commit details
    Browse the repository at this point in the history

  32. Extract aria setting to a helper.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    dec1f0b View commit details
    Browse the repository at this point in the history

  33. Squash two forEach loops.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    f26a559 View commit details
    Browse the repository at this point in the history

  34. Extract sorting custom colors to a helper.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    b5b18b9 View commit details
    Browse the repository at this point in the history

  35. Extract adding labels to a helper.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    3e0bbce View commit details
    Browse the repository at this point in the history

  36. Replace array of arrays with array of objects for explanatory power.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    40d82b1 View commit details
    Browse the repository at this point in the history

  37. Extract two more functions.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    35aeb52 View commit details
    Browse the repository at this point in the history

  38. Extract trimArray() function.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    ca8ab9f View commit details
    Browse the repository at this point in the history

  39. Refactor.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    f2f6239 View commit details
    Browse the repository at this point in the history

  40. Add config option for rows number in content colors.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    9a4899d View commit details
    Browse the repository at this point in the history

  41. Add config option to set limit for color history rows.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    b46058c View commit details
    Browse the repository at this point in the history

  42. Rename config option to 'HistoryRowLimit'.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    55da36b View commit details
    Browse the repository at this point in the history

  43. Remove options destructuring.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    5b33a9a View commit details
    Browse the repository at this point in the history

  44. Rename createColorHistoryRow() function.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    6be3e97 View commit details
    Browse the repository at this point in the history

  45. Make a batch of small fixes.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    92a70fc View commit details
    Browse the repository at this point in the history

  46. Change naming from 

    'tile' to 'color box'.
    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    d63500e View commit details
    Browse the repository at this point in the history

  47. Wrap unit test helpers into a module.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    d96f37e View commit details
    Browse the repository at this point in the history

  48. Refactor.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    b8c5479 View commit details
    Browse the repository at this point in the history

  49. Rename addCustomColorToPanel() -> addColorToHistory().

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    46877d1 View commit details
    Browse the repository at this point in the history

  50. Refactor.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    8b98946 View commit details
    Browse the repository at this point in the history

  51. Remove unnecessary parameter.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    b253639 View commit details
    Browse the repository at this point in the history

  52. Add docs reference about 'config.colorButton_historyRowLimit'.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    1f18cfa View commit details
    Browse the repository at this point in the history

  53. Handle case with no history rows.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    7566f18 View commit details
    Browse the repository at this point in the history

  54. Expose getStyledSpans() as public API.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    bf28a71 View commit details
    Browse the repository at this point in the history

  55. Fix that stupid mistake.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    ed4c3b7 View commit details
    Browse the repository at this point in the history

  56. Fix another stupid bug.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    68bdc0a View commit details
    Browse the repository at this point in the history

  57. Update manual tests to new spec and split them into a few smaller ones.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    53445d3 View commit details
    Browse the repository at this point in the history

  58. Fix bug with aria-posinset for custom colors.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    5744a20 View commit details
    Browse the repository at this point in the history

  59. Update unit tests.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    a786db3 View commit details
    Browse the repository at this point in the history

  60. Extract code for creating color boxes.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    0b23831 View commit details
    Browse the repository at this point in the history

  61. Extract colorHistoryRow class.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    d720625 View commit details
    Browse the repository at this point in the history

  62. Remove config for row limit from manuals where it's not necessary to … 

    …test default value.
    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    d4eaeb0 View commit details
    Browse the repository at this point in the history

  63. Refactor into more object-oriented style.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    1e8664b View commit details
    Browse the repository at this point in the history

  64. Solve problem with automatic color button.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    b1413dd View commit details
    Browse the repository at this point in the history

  65. Reorder functions.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    5784dfe View commit details
    Browse the repository at this point in the history

  66. Replace function with class method.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    0e673c2 View commit details
    Browse the repository at this point in the history

  67. Add container customization.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    dad7e7b View commit details
    Browse the repository at this point in the history

  68. Replace function calls with method.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    07aaaff View commit details
    Browse the repository at this point in the history

  69. Fix indentation.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    80f2328 View commit details
    Browse the repository at this point in the history

  70. Remove unnecessary config from manual tests.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    671cc27 View commit details
    Browse the repository at this point in the history

  71. Remove word 'Class' from class names.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    783433d View commit details
    Browse the repository at this point in the history

  72. Change property reference to class method call.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    696975a View commit details
    Browse the repository at this point in the history

  73. Add row length tracking.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    d5123f7 View commit details
    Browse the repository at this point in the history

  74. Add aria attributes control.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    bf179b0 View commit details
    Browse the repository at this point in the history

  75. Remove excessive abstraction.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    b0d580f View commit details
    Browse the repository at this point in the history

  76. Fix issue with unexpected color order.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    e964baa View commit details
    Browse the repository at this point in the history

  77. Add docs for renderContentColors config option.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    93c5235 View commit details
    Browse the repository at this point in the history

  78. Adjust naming and refactor some small stuff.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    58d9bec View commit details
    Browse the repository at this point in the history

  79. Revamp manual tests.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    6d494f1 View commit details
    Browse the repository at this point in the history

  80. Fix automatic color not changing color to automatic after previous ch… 

    …ange.
    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    ec19f85 View commit details
    Browse the repository at this point in the history

  81. Refresh unit tests.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    8ad60b6 View commit details
    Browse the repository at this point in the history

  82. Fix docs for 'CKEDITOR.tools.getStyledSpans()'.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    eb2d25f View commit details
    Browse the repository at this point in the history

  83. Add code lost during rebase.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    0b06845 View commit details
    Browse the repository at this point in the history

  84. Remove empty lines between manual tests steps.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    e0561ce View commit details
    Browse the repository at this point in the history

  85. Add more specific instructions.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    a88baf5 View commit details
    Browse the repository at this point in the history

  86. Change 'extractColorBox()' method flow to always return something.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    748e7f4 View commit details
    Browse the repository at this point in the history

  87. Replace static method of 'ColorBox' class using constructor.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    04939e5 View commit details
    Browse the repository at this point in the history

  88. Change names for 'setAriaAttributes()' and 'gatherColorInfo()' methods.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    f51cd55 View commit details
    Browse the repository at this point in the history

  89. Replace '==' with '==='.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    774999e View commit details
    Browse the repository at this point in the history

  90. Reuse private method 'moveToBeginning()'.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    d698797 View commit details
    Browse the repository at this point in the history

  91. Merge two conditionals into one.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    dd0b07c View commit details
    Browse the repository at this point in the history

  92. Move 'colorHistory.addColor()' calls into 'setColor()' function.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    caff987 View commit details
    Browse the repository at this point in the history

  93. Change template functions to push output to target source and replace… 

    … '+' signes with ','.
    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    b090b28 View commit details
    Browse the repository at this point in the history

  94. Change 'extractColorBox()' method to something smarter.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    8f75992 View commit details
    Browse the repository at this point in the history

  95. Create 'clickFn' variable in outer scope and pass it to 'renderColors… 

    …()' function.
    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    c5a9849 View commit details
    Browse the repository at this point in the history

  96. Move 'clickFn' implementation to outer scope.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    eec5067 View commit details
    Browse the repository at this point in the history

  97. Fix issue with aria-selected attribute.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    2fbeb3d View commit details
    Browse the repository at this point in the history

  98. Change 'renderContainer()' method to push to target output.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    f76a29e View commit details
    Browse the repository at this point in the history

  99. Replace '+' signs with ','.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    dd07fdf View commit details
    Browse the repository at this point in the history

  100. Hide <tbody></tbody> selectors inside method.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    a9197b9 View commit details
    Browse the repository at this point in the history

  101. Add safety check for automatic color button.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    7caa6c0 View commit details
    Browse the repository at this point in the history

  102. Avoid counting in empty spans.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    f097e9b View commit details
    Browse the repository at this point in the history

  103. Remove extra descriptions from manual test.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    5a0d34b View commit details
    Browse the repository at this point in the history

  104. Add missing word to unit test description.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    d03040c View commit details
    Browse the repository at this point in the history

  105. Add 'null' to return statement.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    2395deb View commit details
    Browse the repository at this point in the history

  106. Change docs wording. 

    Co-Authored-By: Jacek Bogdański <jacekbogd@gmail.com>
    @Dumluregn @jacekbogdanski
    Dumluregn and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    f82970e View commit details
    Browse the repository at this point in the history

  107. Add 'null' to 'return' statement.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    e105cfe View commit details
    Browse the repository at this point in the history

  108. Remove numbering from manual tests.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    b04fd31 View commit details
    Browse the repository at this point in the history

  109. Change naming ('updateAriaAttributes()' -> 'refreshPositions()').

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    fe97e7c View commit details
    Browse the repository at this point in the history

  110. Change naming ('colorHistoryRow.maxLength' -> 'colorHistoryRow.colors… 

    …PerRow').
    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    3b99a3e View commit details
    Browse the repository at this point in the history

  111. Extract 'createClickFunction()'.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    affc0fa View commit details
    Browse the repository at this point in the history

  112. Extract 'createColorStyleTemplate()'.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    84b0e01 View commit details
    Browse the repository at this point in the history

  113. Don't initialize color history or any of it's components if it's disa… 

    …bled.
    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    5f90733 View commit details
    Browse the repository at this point in the history

  114. Add an empty row at history initialization (and update unit test).

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    4088bb8 View commit details
    Browse the repository at this point in the history

  115. Move class definitions to the beginning of the file.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    756daf2 View commit details
    Browse the repository at this point in the history

  116. Move 'colorStyleTemplate()' function call to appropriate place.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    cbc4c23 View commit details
    Browse the repository at this point in the history

  117. Check colors at editor initialization rather than on panel creation.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    182a822 View commit details
    Browse the repository at this point in the history

  118. Update unit tests.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    0022a56 View commit details
    Browse the repository at this point in the history

  119. Add docs about second parameter of 'getStyledSpans()' function.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    2b45f56 View commit details
    Browse the repository at this point in the history

  120. Don't exclude empty spans from 'getStyledSpans()' function.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    54acd04 View commit details
    Browse the repository at this point in the history

  121. Fix editor numbers in unit tests and add unit test for 'config.colorB… 

    …utton_renderContentColors'.
    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    e9a0d1b View commit details
    Browse the repository at this point in the history

  122. Add possibility to find collections in panel.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    76c6dcf View commit details
    Browse the repository at this point in the history

  123. Fix malfunctioning unit test.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    ca8fdaf View commit details
    Browse the repository at this point in the history

  124. Add unit test for 'getStyledSpans()' function.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    0fbbcde View commit details
    Browse the repository at this point in the history

  125. Change behaviour of box selection functions.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    43002bc View commit details
    Browse the repository at this point in the history

  126. Update manual test after change in history rendering.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    06cacfe View commit details
    Browse the repository at this point in the history

  127. Fix code after rebase.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    617a5cb View commit details
    Browse the repository at this point in the history

  128. Add comment about unobvious behaviour.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    840e18e View commit details
    Browse the repository at this point in the history

  129. Force type coercion.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    547154c View commit details
    Browse the repository at this point in the history

  130. Add manual test for auto reselection color box.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    32910fc View commit details
    Browse the repository at this point in the history

  131. Pass arguments as primitives.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    4eeb3ea View commit details
    Browse the repository at this point in the history

  132. Remove 'setClickFn()' method and use var when creating history.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    9dd211e View commit details
    Browse the repository at this point in the history

  133. Simplify check.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    6a13f7a View commit details
    Browse the repository at this point in the history

  134. Encapsulate rendering content colors.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    0668433 View commit details
    Browse the repository at this point in the history

  135. Unify aria attributes for main colorpanel and colorhistory - WiP.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    f344a90 View commit details
    Browse the repository at this point in the history

  136. Add the rest of unit tests.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    269f995 View commit details
    Browse the repository at this point in the history

  137. Fix tests.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    267fec4 View commit details
    Browse the repository at this point in the history

  138. Fix setting aria attributes for basic color panel with history colors.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    def0569 View commit details
    Browse the repository at this point in the history

  139. Add custom title for color history elements.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    6a935c9 View commit details
    Browse the repository at this point in the history

  140. Add manual test for a11y.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    091b629 View commit details
    Browse the repository at this point in the history

  141. Refactor unit test.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    bb5c9d7 View commit details
    Browse the repository at this point in the history

  142. Update tooltip descriptions in tests.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    1fb4d44 View commit details
    Browse the repository at this point in the history

  143. Explicitly set config values.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    073bb5e View commit details
    Browse the repository at this point in the history

  144. Move ColorBox definition to the end of scope.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    0b67736 View commit details
    Browse the repository at this point in the history

  145. Change ColorBox class signature.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    4221468 View commit details
    Browse the repository at this point in the history

  146. Move ColorHistoryRow class definition to the end of scope.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    041cb88 View commit details
    Browse the repository at this point in the history

  147. Move ColorHistory class definition to the end of scope.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    f15c26a View commit details
    Browse the repository at this point in the history

  148. Refactor renumbering panel elements.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    5615a40 View commit details
    Browse the repository at this point in the history

  149. Add 'removePlugins' config to fix CI testing.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    2cefdd0 View commit details
    Browse the repository at this point in the history

  150. Fix colorpanel with 0 rows.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    f25e5d0 View commit details
    Browse the repository at this point in the history

  151. Revert change with adding 'color history' annotation to color boxes.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    ac9092b View commit details
    Browse the repository at this point in the history

  152. Hide horizontal rule if there are no history colors.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    4bedb79 View commit details
    Browse the repository at this point in the history

  153. Adjust naming to the one in docs.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    2a70380 View commit details
    Browse the repository at this point in the history

  154. Explicitly define language in a11y test.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    38faeaf View commit details
    Browse the repository at this point in the history

  155. Change the manual a11y test to only use keyboard.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    5604bb4 View commit details
    Browse the repository at this point in the history

  156. Improve ColorBox class signature.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    7d510a5 View commit details
    Browse the repository at this point in the history

  157. Improve ColorHistory class signature.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    4c7650e View commit details
    Browse the repository at this point in the history

  158. Update tests/plugins/colorbutton/manual/colorhistory/tooltips.md 

    Co-authored-by: Jacek Bogdański <jacekbogd@gmail.com>
    @Dumluregn @jacekbogdanski
    Dumluregn and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    ed4101d View commit details
    Browse the repository at this point in the history

  159. Fix finding spans on IE8.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    619e49e View commit details
    Browse the repository at this point in the history

  160. Fix the rest of tests.

    @Dumluregn @jacekbogdanski
    Dumluregn authored and jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    a911d18 View commit details
    Browse the repository at this point in the history

  161. Small manual test correction.

    @jacekbogdanski
    jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    c35f39a View commit details
    Browse the repository at this point in the history

  162. Added changelog entry.

    @jacekbogdanski
    jacekbogdanski committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    0acc879 View commit details
    Browse the repository at this point in the history