-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose public API for refreshing widget mask and parts #3857
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR introduces unexpected breaking change (~95 test fails on CI) - see review comments for more details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some changes in unit tests needed 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good job 👍
Co-Authored-By: Krzysztof Krztoń <k.krzton@cksource.com>
Rebased onto latest |
What is the purpose of this pull request?
New feature
Does your PR contain necessary tests?
All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.
This PR contains
Did you follow CKEditor 4 code style guide?
Your code should follow guidelines from CKEditor 4 code style guide which helps keep the entire codebase consistent.
What is the proposed changelog entry for this pull request?
What changes did you make?
I created two public methods:
refreshMask()
andrefreshParts()
aliasing accordinglysetupMask()
andsetupParts()
private methods. They needed to be slightly adjusted to handle the case in which one widget part was created at widget initialisation and the other one didn't (e.g. because it wasn't rendered yet). For that reason I also updated existing unit test for setting up parts.Also in unit test there was an issue with IE8 that I tried to resolve for a few hours but still didn't find out why the first call of
elementFromPoint()
after refreshing parts and mask returnsnull
and just added the second call.Which issues your PR resolves?
Closes #3775.