Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for failing test tests/plugins/easyimage/pasteintegration #3870

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Conversation

Comandeer
Copy link
Member

What is the purpose of this pull request?

Failing test fix

Does your PR contain necessary tests?

All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.

This PR contains

  • Unit tests
  • Manual tests

Did you follow CKEditor 4 code style guide?

Your code should follow guidelines from CKEditor 4 code style guide which helps keep the entire codebase consistent.

  • PR is consistent with code style guide

What is the proposed changelog entry for this pull request?

Not needed

What changes did you make?

I've forced clearing the editable before every test. It seems that IE has issues with selecting incorrectly inserted image.

Which issues your PR resolves?

Closes #3869.

@f1ames f1ames self-requested a review February 19, 2020 13:59
@f1ames f1ames self-assigned this Feb 19, 2020
Copy link
Contributor

@f1ames f1ames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@f1ames f1ames merged commit b23048e into major Feb 19, 2020
@CKEditorBot CKEditorBot deleted the t/3869 branch February 19, 2020 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test tests/plugins/easyimage/pasteintegration
2 participants