Remove format button should work with collapsed selection #4049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comandeer
requested changes
May 21, 2020
tests/plugins/removeformat/plugin.js
Outdated
| 'test remove format with collapsed selection': function() { | ||
| this.editorBot.setHtmlWithSelection( '<p><strong>Hello,^</strong></p>' ); | ||
|
|
||
| this.editor.execCommand( 'removeFormat' ); |
There was a problem hiding this comment.
this.editor is used several times in the test – maybe extract it to a variable?
|
Weird, it seems to work correctly for me (on IE11):
Nevertheless, changing this test to always request full input should cover some edge cases 👍 |
Comandeer
approved these changes
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Bug fix
Does your PR contain necessary tests?
All patches that change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.
This PR contains
Did you follow the CKEditor 4 code style guide?
Your code should follow the guidelines from the CKEditor 4 code style guide which helps keep the entire codebase consistent.
What is the proposed changelog entry for this pull request?
What changes did you make?
I reverted changes introduced in #2625 as they seem not necessary and adds this regression. Remove format operates only on inline elements, which is nicely documented here: https://ckeditor.com/docs/ckeditor4/latest/api/CKEDITOR_config.html#cfg-removeFormatTags
Also, it seems like remove format indeed only breaks inline elements:
ckeditor4/plugins/removeformat/plugin.js
Lines 63 to 64 in 846b07e
so, enlarging range only for inline elements may be a good approach. I didn't note any special issues with skipping block elements and the issue #2451 is still covered.
Which issues does your PR resolve?
Closes #4008