Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve importing images from Microsoft Word #4291

Merged
merged 41 commits into from
Oct 16, 2020
Merged

Improve importing images from Microsoft Word #4291

merged 41 commits into from
Oct 16, 2020

Commits on Oct 10, 2020

  1. Add unit tests for extracting images from document with headers and f… 

    …ooters.
    @Comandeer
    Comandeer committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    7a903bb View commit details
    Browse the repository at this point in the history

  2. Add manual test for extracting images from files with headers and foo… 

    …ters.
    @Comandeer
    Comandeer committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    abd0b67 View commit details
    Browse the repository at this point in the history

  3. Parse fragments of RTF to get rid of headers and footers.

    @Comandeer
    Comandeer committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    208148c View commit details
    Browse the repository at this point in the history

  4. Refactor a little code for parsing RTF and add some explanation in co… 

    …mments.
    @Comandeer
    Comandeer committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    ca2d2ab View commit details
    Browse the repository at this point in the history

  5. Remove unnecessary Word temp file.

    @Comandeer
    Comandeer committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    d6969cc View commit details
    Browse the repository at this point in the history

  6. Fix incorrect file name in manual test.

    @Comandeer
    Comandeer committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    664b007 View commit details
    Browse the repository at this point in the history

  7. Add unit tests for unsupported images formats.

    @Comandeer
    Comandeer committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    0d9263b View commit details
    Browse the repository at this point in the history

  8. Add manual test for unsupported images formats.

    @Comandeer
    Comandeer committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    a49df5b View commit details
    Browse the repository at this point in the history

  9. Always put images in results table, even with unknown image format. O… 

    …mit only non-Word (\nonshp) ones.
    @Comandeer
    Comandeer committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    cef84aa View commit details
    Browse the repository at this point in the history

  10. Remove unnecessary Word temp file. AGAIN

    @Comandeer
    Comandeer committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    e83f0d5 View commit details
    Browse the repository at this point in the history

  11. Use of images ids to track which images are already extracted.

    @Comandeer
    Comandeer committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    ed2e48f View commit details
    Browse the repository at this point in the history

  12. Skip WordArt shapes.

    @Comandeer
    Comandeer committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    dc52541 View commit details
    Browse the repository at this point in the history

  13. Update unit test for helpers.

    @Comandeer
    Comandeer committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    c59a402 View commit details
    Browse the repository at this point in the history

  14. Unify image handling between different Pf* plugins.

    @Comandeer
    Comandeer committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    716e9aa View commit details
    Browse the repository at this point in the history

  15. Move RTF helpers directly to the common filter.

    @Comandeer
    Comandeer committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    f5eb7c0 View commit details
    Browse the repository at this point in the history

  16. Enhance RTF parser.

    @Comandeer
    Comandeer committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    3c7f44a View commit details
    Browse the repository at this point in the history

  17. Implement extracting content from RTF groups and use it to replace th… 

    …e regex-based image extraction mechanism.
    @Comandeer
    Comandeer committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    16fcf1c View commit details
    Browse the repository at this point in the history

  18. Handle images after Word default filter.

    @Comandeer
    Comandeer committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    e738304 View commit details
    Browse the repository at this point in the history

  19. Always treat images without ids as unique.

    @Comandeer
    Comandeer committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    8935980 View commit details
    Browse the repository at this point in the history

  20. Fix failing tests for image filter.

    @Comandeer
    Comandeer committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    aa394fb View commit details
    Browse the repository at this point in the history

  21. Rephrase manual test expected section.

    @Comandeer
    Comandeer committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    9d9f9f5 View commit details
    Browse the repository at this point in the history

  22. Add error for unsupported image formats.

    @Comandeer
    Comandeer committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    854efb6 View commit details
    Browse the repository at this point in the history

  23. Add error for unsupported images and helper for getting image type.

    @Comandeer
    Comandeer committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    e85b04b View commit details
    Browse the repository at this point in the history

  24. Extend expected in unsupported image types manual test.

    @Comandeer
    Comandeer committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    48b219f View commit details
    Browse the repository at this point in the history

  25. Add error for the case, when there are different amount of images ext… 

    …racted from HTML and RTF.
    @Comandeer
    Comandeer committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    9a2ad76 View commit details
    Browse the repository at this point in the history

  26. Add unit tests for duplicated images.

    @Comandeer
    Comandeer committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    c4b1703 View commit details
    Browse the repository at this point in the history

  27. Try to differiantiate between duplicated images and the same image in… 

    … different format.
    @Comandeer
    Comandeer committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    c1af458 View commit details
    Browse the repository at this point in the history

  28. Add manual test for duplicated images.

    @Comandeer
    Comandeer committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    a301d51 View commit details
    Browse the repository at this point in the history

  29. Make CKEDITOR.pasteFilters the real alias of CKEDITOR.plugins.pasteto… 

    …ols.filters.
    @Comandeer
    Comandeer committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    db845ae View commit details
    Browse the repository at this point in the history

  30. Update API docs.

    @Comandeer
    Comandeer committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    7a226e1 View commit details
    Browse the repository at this point in the history

  31. Remove unnecessary Word temporary file.

    @Comandeer
    Comandeer committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    7098e74 View commit details
    Browse the repository at this point in the history

  32. Add additional tests for PfLO.

    @Comandeer
    Comandeer committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    a322b3c View commit details
    Browse the repository at this point in the history

  33. Add autogrow plugin to manual tests.

    @Comandeer
    Comandeer committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    8230a16 View commit details
    Browse the repository at this point in the history

  34. Inlined one var in unit tests.

    @f1ames @Comandeer
    f1ames authored and Comandeer committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    2c5b100 View commit details
    Browse the repository at this point in the history

  35. Extract recognizable image types to the separate property.

    @Comandeer
    Comandeer committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    f614889 View commit details
    Browse the repository at this point in the history

  36. Update API docs for RTF helpers.

    @Comandeer
    Comandeer committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    5d7d89a View commit details
    Browse the repository at this point in the history

  37. Fix wrong indentation.

    @Comandeer
    Comandeer committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    2daaeae View commit details
    Browse the repository at this point in the history

  38. Add additional tests for RTF helpers.

    @Comandeer
    Comandeer committed Oct 10, 2020
    Configuration menu
    Copy the full SHA
    1d952c0 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2020

  1. Add additional unit tests.

    @Comandeer
    Comandeer committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    4c46207 View commit details
    Browse the repository at this point in the history

  2. Strip off all drawn objects.

    @Comandeer
    Comandeer committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    15e9904 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2020

  1. Changelog entry.

    @f1ames
    f1ames committed Oct 16, 2020
    Configuration menu
    Copy the full SHA
    597c28f View commit details
    Browse the repository at this point in the history