Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent editor creation on detached element #4463

Merged
merged 103 commits into from
Apr 23, 2021
Merged

Prevent editor creation on detached element #4463

merged 103 commits into from
Apr 23, 2021

Commits on Apr 23, 2021

  1. WIP: Add working PoC with manual test

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    fee22b4 View commit details
    Browse the repository at this point in the history
  2. Clean up manual test & delayed creation

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    2e1ac29 View commit details
    Browse the repository at this point in the history
  3. Prevent reading property from null config

    Explicite return false from delayCreation function
    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    983a088 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ee25c5c View commit details
    Browse the repository at this point in the history
  5. Correct manual test scenario

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    2fe14ab View commit details
    Browse the repository at this point in the history
  6. Move clearInterval before createInstance

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    8993ae9 View commit details
    Browse the repository at this point in the history
  7. Handle with delay from config

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    3afdff9 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    0a05e43 View commit details
    Browse the repository at this point in the history
  9. Refactor delayed creation function

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    e4b7c6b View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    81fcd1d View commit details
    Browse the repository at this point in the history
  11. Rephrase function description

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    53d852a View commit details
    Browse the repository at this point in the history
  12. Add unit tests

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    8d40716 View commit details
    Browse the repository at this point in the history
  13. Refactor names & add config docs

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    c62e727 View commit details
    Browse the repository at this point in the history
  14. Fix cfg docs description & error name

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    957e7e7 View commit details
    Browse the repository at this point in the history
  15. Update config to proper naming

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    44a9927 View commit details
    Browse the repository at this point in the history
  16. Fix comment: editor mode is a string

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    9a44784 View commit details
    Browse the repository at this point in the history
  17. Simplyfy delayCreation function logic

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    416c701 View commit details
    Browse the repository at this point in the history
  18. REmoved else with comment

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    b58ecae View commit details
    Browse the repository at this point in the history
  19. Rename config function argument

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    d7dd404 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    6ab5328 View commit details
    Browse the repository at this point in the history
  21. Fix extra space before function keyword

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    9f8275c View commit details
    Browse the repository at this point in the history
  22. Fix test naming & code style

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    ceb6da1 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    e1fa2f4 View commit details
    Browse the repository at this point in the history
  24. Fix manual test code style & description

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    2fe90d1 View commit details
    Browse the repository at this point in the history
  25. Correct manual test description

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    fce5286 View commit details
    Browse the repository at this point in the history
  26. Fix typo in config comment

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    b88287d View commit details
    Browse the repository at this point in the history
  27. Remove unnecessary variable assigment

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    66ab18a View commit details
    Browse the repository at this point in the history
  28. Replace bug with feature tag

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    e4740cc View commit details
    Browse the repository at this point in the history
  29. Add creation warnings

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    7cc43ac View commit details
    Browse the repository at this point in the history
  30. Simplyfy editor creation callback

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    2ea64e1 View commit details
    Browse the repository at this point in the history
  31. Configuration menu
    Copy the full SHA
    d7cb945 View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    00bf0ee View commit details
    Browse the repository at this point in the history
  33. Make test names starts with lowercase

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    128ed83 View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    5d4f83f View commit details
    Browse the repository at this point in the history
  35. Remove unused code in test

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    4da8a22 View commit details
    Browse the repository at this point in the history
  36. Split manual test onto two separate

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    c2aee28 View commit details
    Browse the repository at this point in the history
  37. Add test with warn stubbing

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    15b0642 View commit details
    Browse the repository at this point in the history
  38. Configuration menu
    Copy the full SHA
    bf0343d View commit details
    Browse the repository at this point in the history
  39. Configuration menu
    Copy the full SHA
    4748f47 View commit details
    Browse the repository at this point in the history
  40. Add test case for editor without config

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    d8eca17 View commit details
    Browse the repository at this point in the history
  41. Configuration menu
    Copy the full SHA
    eda4cf7 View commit details
    Browse the repository at this point in the history
  42. Remove duplicated empty line

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    493ad89 View commit details
    Browse the repository at this point in the history
  43. Join var statements, removed version tag

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    d02bdb6 View commit details
    Browse the repository at this point in the history
  44. Configuration menu
    Copy the full SHA
    0873997 View commit details
    Browse the repository at this point in the history
  45. Configuration menu
    Copy the full SHA
    db15f7c View commit details
    Browse the repository at this point in the history
  46. Prevents infinite setInterval

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    34b3f2a View commit details
    Browse the repository at this point in the history
  47. Bump timeout before verify test

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    7d0429a View commit details
    Browse the repository at this point in the history
  48. Correct var names

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    6ce9878 View commit details
    Browse the repository at this point in the history
  49. Add issue reference

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    0a1eb94 View commit details
    Browse the repository at this point in the history
  50. Simplyfy delay creation logic

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    668a170 View commit details
    Browse the repository at this point in the history
  51. Correct delayIfDetach config docs

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    08ab347 View commit details
    Browse the repository at this point in the history
  52. Replace warn msg with code errors

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    5d674c9 View commit details
    Browse the repository at this point in the history
  53. Fix whitespaces in test

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    f95cdc6 View commit details
    Browse the repository at this point in the history
  54. Add precise description for test

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    88b7c96 View commit details
    Browse the repository at this point in the history
  55. Correct config API comment

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    a4229e6 View commit details
    Browse the repository at this point in the history
  56. Add since tags for config options

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    6977767 View commit details
    Browse the repository at this point in the history
  57. Configuration menu
    Copy the full SHA
    7fd0431 View commit details
    Browse the repository at this point in the history
  58. Correct API comments

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    441115c View commit details
    Browse the repository at this point in the history
  59. Added msgs to tests

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    e8ccc14 View commit details
    Browse the repository at this point in the history
  60. Debug CI failing test (try with spy)

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    e91c29d View commit details
    Browse the repository at this point in the history
  61. Debug warn on CI

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    1b71064 View commit details
    Browse the repository at this point in the history
  62. Configuration menu
    Copy the full SHA
    176b3ca View commit details
    Browse the repository at this point in the history
  63. Cleanup warn test

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    5d95920 View commit details
    Browse the repository at this point in the history
  64. Add timer to manual test [skip ci]

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    56bdc66 View commit details
    Browse the repository at this point in the history
  65. Improve test messages [skip ci]

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    ccfa4db View commit details
    Browse the repository at this point in the history
  66. Configuration menu
    Copy the full SHA
    964dafe View commit details
    Browse the repository at this point in the history
  67. Configuration menu
    Copy the full SHA
    c3e8067 View commit details
    Browse the repository at this point in the history
  68. Add CKE warn for delayed creation

     Correct warnings custom data.
    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    4a5dc8e View commit details
    Browse the repository at this point in the history
  69. Add warn checks and correct wait time.

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    374b283 View commit details
    Browse the repository at this point in the history
  70. Configuration menu
    Copy the full SHA
    30e4b63 View commit details
    Browse the repository at this point in the history
  71. Rework warn tests (interval & callback)

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    cd09c6d View commit details
    Browse the repository at this point in the history
  72. Polish manual tests.

    Dumluregn authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    91f8803 View commit details
    Browse the repository at this point in the history
  73. Configuration menu
    Copy the full SHA
    ab9b36a View commit details
    Browse the repository at this point in the history
  74. Rename warn parameter: 'mode'->'method'.

    Dumluregn authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    39d84b8 View commit details
    Browse the repository at this point in the history
  75. Fix the example code.

    Dumluregn authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    42748e0 View commit details
    Browse the repository at this point in the history
  76. Polish docs.

    Dumluregn authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    594449c View commit details
    Browse the repository at this point in the history
  77. Update IE note in manual tests.

    Dumluregn authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    fbad5d5 View commit details
    Browse the repository at this point in the history
  78. Configuration menu
    Copy the full SHA
    a9611ff View commit details
    Browse the repository at this point in the history
  79. Configuration menu
    Copy the full SHA
    b22493a View commit details
    Browse the repository at this point in the history
  80. Fix test naming

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    d5ece7e View commit details
    Browse the repository at this point in the history
  81. Configuration menu
    Copy the full SHA
    c24e56b View commit details
    Browse the repository at this point in the history
  82. Add delay for inline editor

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    0eef280 View commit details
    Browse the repository at this point in the history
  83. Add distinction in assert messages

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    489afe3 View commit details
    Browse the repository at this point in the history
  84. Add ticket ref & group var definitions.

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    c14a48b View commit details
    Browse the repository at this point in the history
  85. Configuration menu
    Copy the full SHA
    65f3d1b View commit details
    Browse the repository at this point in the history
  86. Add detached tests tool

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    f643e14 View commit details
    Browse the repository at this point in the history
  87. Split unit test by editor creation method

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    9d5ad80 View commit details
    Browse the repository at this point in the history
  88. Prepare valid inlineAll test

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    01cc19c View commit details
    Browse the repository at this point in the history
  89. replace for with tools.forEach

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    c86acdd View commit details
    Browse the repository at this point in the history
  90. Configuration menu
    Copy the full SHA
    c9d2a86 View commit details
    Browse the repository at this point in the history
  91. Polish unit tests.

    Dumluregn authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    0a563d7 View commit details
    Browse the repository at this point in the history
  92. Fix unit test for replaceAll() on IE.

    Dumluregn authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    7c493ec View commit details
    Browse the repository at this point in the history
  93. Add intendation to Expected sections

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    4775099 View commit details
    Browse the repository at this point in the history
  94. Correct api comments

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    939e4c4 View commit details
    Browse the repository at this point in the history
  95. Configuration menu
    Copy the full SHA
    128ac96 View commit details
    Browse the repository at this point in the history
  96. Improve API docs slightly.

    f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    fe4e94c View commit details
    Browse the repository at this point in the history
  97. Configuration menu
    Copy the full SHA
    b241e8f View commit details
    Browse the repository at this point in the history
  98. Change docs variable type to dom.element

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    f4c19a9 View commit details
    Browse the repository at this point in the history
  99. Configuration menu
    Copy the full SHA
    3d6e718 View commit details
    Browse the repository at this point in the history
  100. Improve API docs wording.

    f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    d0726a4 View commit details
    Browse the repository at this point in the history
  101. Ignore dev console manual test for mobile

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    ee13308 View commit details
    Browse the repository at this point in the history
  102. Add custom detach editor test for mobile

    sculpt0r authored and f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    806e0f0 View commit details
    Browse the repository at this point in the history
  103. Add changelog entry.

    f1ames committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    46cd968 View commit details
    Browse the repository at this point in the history