Updated Trac and GitHub issue references #470

mlewand · 2017-06-06T08:18:06Z

What is the purpose of this pull request?

Maintenance Task

What changes did you make?

Replaced existing #<number> references with permalinks to Trac. Also updated tags in manual tests, from format <number> to trac<number>.

GitHub references has been updated from gh<number> to <number> in manual tests, and #<number> in js files.

Closes #433.

This issue does not require changelog entry.

Comandeer · 2017-06-06T11:30:34Z

core/editable.js

 				if ( this.insertElementIntoRange( element, range ) ) {
 					range.moveToPosition( element, CKEDITOR.POSITION_AFTER_END );

 					// If we're inserting a block element, the new cursor position must be
-					// optimized. (#3100,#5436,#8950)
+					// optimized. (http://dev.ckeditor.com/ticket/3100,#5436,#8950)


Not all tickets were changed in this line.

Comandeer · 2017-06-06T11:31:45Z

core/editable.js

@@ -1172,7 +1172,7 @@
 				}

 				// Prevent Webkit/Blink from going rogue when joining
-				// blocks on BACKSPACE/DEL (#11861,#9998).
+				// blocks on BACKSPACE/DEL (http://dev.ckeditor.com/ticket/11861,#9998).


Not all tickets were changed in this line.

Comandeer · 2017-06-06T11:33:16Z

core/htmldataprocessor.js

@@ -192,7 +192,7 @@
 			data.writeChildrenHtml( writer );
 			data = writer.getHtml( true );

-			// Restore those non-HTML protected source. (#4475,#4880)
+			// Restore those non-HTML protected source. (http://dev.ckeditor.com/ticket/4475,#4880)


Not all tickets were changed in this line.

Comandeer · 2017-06-06T11:37:31Z

plugins/colorbutton/plugin.js

 						return isUnstylable( element );
 					} : function( element ) {
-						// Fore color style must be applied inside links instead of around it. (#4772,#6908)
+						// Fore color style must be applied inside links instead of around it. (http://dev.ckeditor.com/ticket/4772,#6908)


Not all tickets were changed in this line.

Comandeer · 2017-06-06T11:38:01Z

plugins/devtools/plugin.js

@@ -10,7 +10,7 @@ CKEDITOR.plugins.add( 'devtools', {
 		editor._.showDialogDefinitionTooltips = 1;
 	},
 	onLoad: function() {
-		CKEDITOR.document.appendStyleText( CKEDITOR.config.devtools_styles || '#cke_tooltip { padding: 5px; border: 2px solid #333; background: #ffffff }' +
+		CKEDITOR.document.appendStyleText( CKEDITOR.config.devtools_styles || '#cke_tooltip { padding: 5px; border: 2px solid http://dev.ckeditor.com/ticket/333; background: #ffffff }' +


It's not a ticket number.

Comandeer · 2017-06-06T12:10:46Z

tests/plugins/tableselection/manual/outsidetable.md

@@ -1,5 +1,5 @@
 @bender-ui: collapsed
-@bender-tags: tc, 16755, 4.7.0, tp1579
+@bender-tags: tc, 16755, 4.7.0, tptrac1579


It's tp ticket number, not trac. Additionally trac ticket is not changed.

Comandeer · 2017-06-06T12:12:47Z

tests/plugins/widgetselection/manual/image2.md

@@ -1,4 +1,4 @@
-@bender-tags: 4.6.1, tc, 11064, widgetselection
+@bender-tags: 4.6.1, tc, 1trac1064, widgetselection


It shouldn't be changed this way.

Comandeer · 2017-06-06T12:13:05Z

tests/plugins/widgetselection/manual/selectall.md

@@ -1,4 +1,4 @@
-@bender-tags: 4.6.1, tc, 11064, widgetselection
+@bender-tags: 4.6.1, tc, 1trac1064, widgetselection


This shouldn't be changed this way.

Comandeer · 2017-06-06T12:13:29Z

tests/tickets/11616/1.md

@@ -1,5 +1,5 @@
 @bender-ui: collapsed
-@bender-tags: wyswigarea, tc, 4.5.2, 11616, 9715
+@bender-tags: wyswigarea, tc, 4.5.2, 1trac1616, 9715


This shouldn't be changed this way.

Comandeer · 2017-06-06T12:13:43Z

tests/tickets/11616/2.md

@@ -1,5 +1,5 @@
 @bender-ui: collapsed
-@bender-tags: toolbar, tc, 4.5.2, 11616, 7360
+@bender-tags: toolbar, tc, 4.5.2, 1trac1616, 7360


This shouldn't be changed this way.

mlewand · 2017-06-06T16:32:30Z

Added requested changes.

Comandeer · 2017-06-07T09:02:11Z

core/editable.js

@@ -998,7 +998,7 @@
 					var keyCode = evt.data.domEvent.getKey(),
 						isHandled;

-					// Prevent of reading path of empty range (#13096, #gh457).
+					// Prevent of reading path of empty range (http://dev.ckeditor.com/ticket/13096, http://dev.ckeditor.com/ticket/457).


GH ticket number is now changed into trac link.

Comandeer · 2017-06-07T09:02:35Z

core/editable.js

@@ -1186,7 +1186,7 @@
 						if ( !( key in backspaceOrDelete ) )
 							return;

-						// Prevent of reading path of empty range (#13096, #gh457).
+						// Prevent of reading path of empty range (http://dev.ckeditor.com/ticket/13096, http://dev.ckeditor.com/ticket/457).


GH ticket number is now changed into trac link.

Comandeer · 2017-06-07T10:26:16Z

tests/core/selection/manual/focusafterundoing.md

@@ -1,4 +1,4 @@
-@bender-tags: selection, focus, tc, 4.4.6, 12630, 12337
+@bender-tags: selection, focus, tc, 4.4.6, 12630, trac12337


There is still second ticket number, which was not changed.

Comandeer · 2017-06-07T10:26:32Z

tests/core/selection/manual/selectionafterfocusing.md

@@ -1,4 +1,4 @@
-@bender-tags: selection, focus, tc, 4.4.6, 12630, 12337
+@bender-tags: selection, focus, tc, 4.4.6, 12630, trac12337


There is still second ticket number, which was not changed.

Comandeer · 2017-06-07T10:31:43Z

tests/plugins/newpage/manual/selectionafternewpage.md

@@ -1,4 +1,4 @@
-@bender-tags: selection, focus, tc, 4.4.6, 12630, 12337
+@bender-tags: selection, focus, tc, 4.4.6, 12630, trac12337


There is still second ticket number, which was not changed.

Comandeer · 2017-06-07T10:35:53Z

tests/plugins/tableselection/tableselection.js

@@ -20,7 +20,7 @@
 	}

 	var tests = {
-		// (#258, #tp2247)
+		// (http://dev.ckeditor.com/ticket/258, #tp2247)


It seems like this ticket number is from unknown source… It does not fit to trac or our GH.

Since this issue is not available to the public, I decided to remove it all along.

mlewand · 2017-06-07T11:57:30Z

I found a couple extra missing references, fixed in 3d04295.

Comandeer · 2017-06-07T13:10:31Z

tests/core/selection/manual/focusaftersettingdata.md

@@ -1,4 +1,4 @@
-@bender-tags: selection, focus, tc, 4.4.6, 12630, 12337
+@bender-tags: selection, focus, tc, 4.4.6, 12630, trac12337


Still one ticket number left.

mlewand · 2017-06-07T13:47:14Z

Fixed. I did not rebase the branch, so that comments won't lose the reference.

Comandeer

LGTM. But it would be nice to rebase the branch and fix also the newly added ticket numbers.

mlewand · 2017-06-07T14:14:09Z

and fix also the newly added ticket numbers

It's a relatively recent PR, and it's latest common commit with master is 83a5ae1.

But it would be nice to rebase the branch

Done.

Comandeer self-requested a review June 6, 2017 11:15

Comandeer requested changes Jun 6, 2017

View reviewed changes

Comandeer requested changes Jun 7, 2017

View reviewed changes

Comandeer self-requested a review June 7, 2017 12:26

Comandeer requested changes Jun 7, 2017

View reviewed changes

Comandeer self-requested a review June 7, 2017 13:50

Comandeer reviewed Jun 7, 2017

View reviewed changes

Comandeer approved these changes Jun 7, 2017

View reviewed changes

mlewand added 14 commits June 7, 2017 16:17

First batch of Trac references updated.

c74a835

Fixed another batch of Trac references.

c18e61c

More references fixed.

83d7418

Updated Trac references in manual tests.

baf084c

Updated GitHub ticket references to the new format.

f85ccfa

Replaced missed GitHub references.

f473b4d

Fixed hexes replaced with GitHub links.

3341033

Docs: reverted some ticket link inlines.

8755692

Tests: fixed TargetProcess references.

e83da15

Tests: fixed remaining Trac ferences. [skip ci]

f4b4a5b

Revered changes made to an external lib. [skip ci]

dd49f07

Adjusted more references. [skip ci]

c0e03bc

Tests found few more unchanged Trac references. [skip ci]

329791a

Added missing Trac reference. [skip ci]

50f0417

Comandeer merged commit 3b7f188 into ckeditor:master Jun 7, 2017

Comandeer deleted the t/433 branch June 7, 2017 14:24

mlewand mentioned this pull request Jun 7, 2017

[#17020] Unit test for loosing focus in divarea editor #364

Merged

msamsel mentioned this pull request Jun 12, 2017

[#17028] Tabbing through inline editor causes JavaScript error. #451

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated Trac and GitHub issue references #470

Updated Trac and GitHub issue references #470

mlewand commented Jun 6, 2017

Comandeer Jun 6, 2017

Comandeer Jun 6, 2017

Comandeer Jun 6, 2017

Comandeer Jun 6, 2017

Comandeer Jun 6, 2017

Comandeer Jun 6, 2017

Comandeer Jun 6, 2017

Comandeer Jun 6, 2017

Comandeer Jun 6, 2017

Comandeer Jun 6, 2017

mlewand commented Jun 6, 2017

Comandeer Jun 7, 2017

Comandeer Jun 7, 2017

Comandeer Jun 7, 2017

Comandeer Jun 7, 2017

Comandeer Jun 7, 2017

Comandeer Jun 7, 2017

mlewand Jun 7, 2017

mlewand commented Jun 7, 2017

Comandeer Jun 7, 2017

mlewand commented Jun 7, 2017

Comandeer left a comment

mlewand commented Jun 7, 2017

		@@ -1,4 +1,4 @@
		@bender-tags: 4.6.1, tc, 11064, widgetselection
		@bender-tags: 4.6.1, tc, 1trac1064, widgetselection

		@@ -1,4 +1,4 @@
		@bender-tags: selection, focus, tc, 4.4.6, 12630, 12337
		@bender-tags: selection, focus, tc, 4.4.6, 12630, trac12337

Updated Trac and GitHub issue references #470

Updated Trac and GitHub issue references #470

Conversation

mlewand commented Jun 6, 2017

What is the purpose of this pull request?

What changes did you make?

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mlewand commented Jun 6, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mlewand commented Jun 7, 2017

Choose a reason for hiding this comment

mlewand commented Jun 7, 2017

Comandeer left a comment

Choose a reason for hiding this comment

mlewand commented Jun 7, 2017