Updated deps and removed package-lock.json file #5102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacekbogdanski
changed the title
sculpt0r
suggested changes
Feb 23, 2022
There was a problem hiding this comment.
I removed the entire node_muldes and reinstalled deps again.
- grunt based tasks work fine (linting, img minification, packing ckeditor_base.js)
- I tried to run
grunt lessfromdev/tasks/samples.js- but it fails due to dependency in another repocksource-samples-frameworkand I don't have access to it
However, it looks like an old error (probably we could extract an issue for it? @jacekbogdanski ) - bender and randomly ran tests also works fine
Beside that... Looks fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated our deps and removed
package-lock.jsonas we discussed some time ago that this file may actually force library consumers to use a specific version of the package that should be rather specified inpackage.json. There is a nice discussion regarding this issue: yarnpkg/yarn#838 (comment)No
package-lock.jsonmeans also a better understanding of potential breaking changes during development, so we actually want to see ASAP if some dependency starts to break it.