Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependancy between toolbar and notification plugin #631

Merged
merged 9 commits into from
Jul 17, 2017
Merged

Conversation

msamsel
Copy link
Contributor

@msamsel msamsel commented Jul 10, 2017

What is the purpose of this pull request?

bug fix

Does your PR contain necessary tests?

I hope so :)

This PR contains

  • Unit tests
  • Manual tests

What changes did you make?

  • Made update to notification to skip section related to toolbar position, if toolbar position doesn't exists.
  • Made some small changes in unit test to include toolbar in tests.
  • Add few new unit test to test cases of editor without toolbar
  • Add dependancy to clipboard plugin to use toolbar. It appears that earlier clipboard base on dependancy included in notification.

close #491

@jonnott
Copy link

jonnott commented Jul 16, 2017

+1 love it - let's get this baby merged ;)

@jonnott
Copy link

jonnott commented Jul 22, 2017

Will this be in v4.7.2 then? If not, how do we ensure it is...? ;)

@Comandeer
Copy link
Member

Yes, it'll be a part of 4.7.2 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants