Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for unit test for IE8 #661

Merged
merged 1 commit into from
Jul 21, 2017
Merged

Fix for unit test for IE8 #661

merged 1 commit into from
Jul 21, 2017

Conversation

msamsel
Copy link
Contributor

@msamsel msamsel commented Jul 19, 2017

What is the purpose of this pull request?

bug fix

Does your PR contain necessary tests?

no it fix test

This PR contains

  • Unit tests
  • Manual tests

What changes did you make?

IE8 setTimeout failed when regular function was returned, now code is surround with anonymous function and it works on IE8.

close #660

@Comandeer Comandeer self-requested a review July 21, 2017 09:37
Copy link
Member

@Comandeer Comandeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Comandeer Comandeer merged commit 36394a4 into master Jul 21, 2017
@Comandeer Comandeer deleted the t/660 branch July 21, 2017 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants