[#877] Fix for error in PFW when bullets use special char #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msamsel
changed the title
f1ames
suggested changes
Sep 29, 2017
| @@ -1085,7 +1085,8 @@ | |||
| symbol = element.attributes[ 'cke-symbol' ]; | |||
|
|
|||
| element.forEach( function( node ) { | |||
| if ( !removed && node.value.match( symbol.replace( ')', '\\)' ).replace( '(', '' ) ) ) { | |||
| // Changing `match` -> `indexOf`, symbol is String not RegExp (#877). | |||
There was a problem hiding this comment.
This comment is true, however if you look at the match docs:
A regular expression object. If a non-RegExp object obj is passed, it is implicitly converted to a RegExp by using new RegExp(obj)...
which means it can be used with a String too. I assume what was the intention of this comment, but maybe it will be better to put here something like:
Since symbol may contains special characters we use simple
indexOfinstead of RegExp which is sufficient (#877).
|
|
||
| ---- | ||
| 1. Open browser console. | ||
| 1. Open [file](../generated/_fixtures/Unordered_list_special_char_bullet/Unordered_list_special_char_bullet.docx) in Word. |
There was a problem hiding this comment.
Maybe you can put file name here as a link [Unordered_list_special_char_bullet.docx](...)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Bug fix
Does your PR contain necessary tests?
yes
This PR contains
What changes did you make?
Close #877