Skip to content

Commit

Permalink
Merge pull request #419 from ckeditor/migrate-to-new-installation-met…
Browse files Browse the repository at this point in the history
…hods

Feature: Change the implementation to only depend on types from the CKEditor packages and not runtime code to make the integration work with existing and new installation methods.
  • Loading branch information
filipsobol committed Jun 4, 2024
2 parents af306f6 + aea2ae0 commit 711aae3
Show file tree
Hide file tree
Showing 20 changed files with 1,750 additions and 1,469 deletions.
3 changes: 0 additions & 3 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,6 @@ jobs:
- checkout
- bootstrap_repository_command
- prepare_environment_command
- run:
name: Build CKEditor 5 instance
command: yarn run build-ckeditor
- run:
name: Execute ESLint
command: yarn run lint
Expand Down
8 changes: 1 addition & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ Because of the breaking changes in the Angular library output format, the `@cked
<tr>
<td><code>^6</code></td>
<td><code>13+</code></td>
<td>Requires CKEditor&nbsp;5 at least in version <a href="https://github.com/ckeditor/ckeditor5/releases/tag/v37.0.0">37</a>.</td>
<td>Requires CKEditor&nbsp;5 at least in version <a href="https://github.com/ckeditor/ckeditor5/releases/tag/v42.0.0">42</a>.</td>
</tr>
<tr>
<td><code>^5</code></td>
Expand Down Expand Up @@ -96,12 +96,6 @@ This repository contains the following code:

### Testing the component (demo)

First, the CKEditor 5 build should be created out of source files:

```bash
npm run build-ckeditor
```

To open the demo application using the component, run:

```bash
Expand Down
2 changes: 2 additions & 0 deletions angular.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
"src/assets"
],
"styles": [
"ckeditor5/ckeditor5.css",
"src/styles.css"
],
"scripts": [],
Expand Down Expand Up @@ -82,6 +83,7 @@
"tsConfig": "tsconfig.spec.json",
"karmaConfig": "karma.conf.js",
"styles": [
"ckeditor5/ckeditor5.css",
"src/styles.css"
],
"scripts": [],
Expand Down
96 changes: 0 additions & 96 deletions ckeditor/src/ckeditor.ts

This file was deleted.

104 changes: 0 additions & 104 deletions ckeditor/tsconfig.json

This file was deleted.

108 changes: 0 additions & 108 deletions ckeditor/webpack.config.js

This file was deleted.

Loading

0 comments on commit 711aae3

Please sign in to comment.