Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make editor id public #367

Closed
ulrikdom opened this issue Apr 26, 2023 · 3 comments · Fixed by #373
Closed

Make editor id public #367

ulrikdom opened this issue Apr 26, 2023 · 3 comments · Fixed by #373
Assignees
Labels
squad:devops Issue to be handled by the Devops team. type:improvement
Milestone

Comments

@ulrikdom
Copy link

Hi.

I want to implement the context watchdog to implement better error-handling. But since I can't access the id of the editor it's impossible to know which editor that emited which event. Could you make the id property of the component public?

@pomek
Copy link
Member

pomek commented May 12, 2023

Hi @ulrikdom,

Just to make sure we talk about the same thing. Is it this property? 👇

@pomek pomek added pending:feedback This issue is blocked by necessary feedback. squad:devops Issue to be handled by the Devops team. labels May 12, 2023
@ulrikdom
Copy link
Author

Yes, that's the one

@pomek pomek added type:improvement and removed pending:feedback This issue is blocked by necessary feedback. labels May 12, 2023
@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label May 22, 2023
@pomek
Copy link
Member

pomek commented May 22, 2023

Let's add a method: getId() that returns a value of the id property.

@psmyrek psmyrek self-assigned this May 31, 2023
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels May 31, 2023
@pomek pomek closed this as completed in #373 Jun 1, 2023
pomek added a commit that referenced this issue Jun 1, 2023
Other: Added the `getId()` method that returns the component id. Closes #367.
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Jun 1, 2023
@CKEditorBot CKEditorBot added this to the iteration 64 milestone Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad:devops Issue to be handled by the Devops team. type:improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants