Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Marked basic style attributes with the AttributeProperties#isFormatting property #86

Merged
merged 1 commit into from
Mar 29, 2019

Conversation

mlewand
Copy link
Contributor

@mlewand mlewand commented Mar 29, 2019

Suggested merge commit message (convention)

Feature: Marked basic style attributes as a formatting using the AttributeProperties#isFormatting property. Closes ckeditor/ckeditor5#1664.


Additional information

There are 2 more pull requests related with this in respective repositories.

All The PRs are referenced in ckeditor/ckeditor5#1664.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 634e1cb on t/ckeditor5/1664 into bc3710e on master.

@jodator jodator self-requested a review March 29, 2019 12:17
Copy link
Contributor

@jodator jodator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jodator jodator merged commit fcfba54 into master Mar 29, 2019
@jodator jodator deleted the t/ckeditor5/1664 branch March 29, 2019 12:45
@mcrapts
Copy link

mcrapts commented Apr 2, 2019

This PR uses the editor.model.schema.setAttributeProperties() method which does not exist. The result is that I'm unable to build CKEditor from source.

@mlewand
Copy link
Contributor Author

mlewand commented Apr 2, 2019

@mcrapts you should either use stable release tags or latest master branch on all repos. schema.setAttributeProperties() is already out, merged to the master branch in ckeditor5-engine repo.

@mcrapts
Copy link

mcrapts commented Apr 2, 2019

I see, you're right Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants