Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Used EditorUI as a DecoupledEditorUI parent class. #16

Merged
merged 2 commits into from
Jun 29, 2018
Merged

Used EditorUI as a DecoupledEditorUI parent class. #16

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf4bc72
Used EditorUI as a DecoupledEditorUI parent class.
oskarwrobel Jun 26, 2018
61e89df
Removed unnecessary test case.
oskarwrobel Jun 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 5 additions & 34 deletions src/decouplededitorui.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,43 +7,21 @@
* @module editor-decoupled/decouplededitorui
*/

import ComponentFactory from '@ckeditor/ckeditor5-ui/src/componentfactory';
import FocusTracker from '@ckeditor/ckeditor5-utils/src/focustracker';
import EditorUI from '@ckeditor/ckeditor5-core/src/editor/editorui';
import enableToolbarKeyboardFocus from '@ckeditor/ckeditor5-ui/src/toolbar/enabletoolbarkeyboardfocus';
import normalizeToolbarConfig from '@ckeditor/ckeditor5-ui/src/toolbar/normalizetoolbarconfig';

/**
* The decoupled editor UI class.
*
* @implements module:core/editor/editorui~EditorUI
* @extends module:core/editor/editorui~EditorUI
*/
export default class DecoupledEditorUI {
export default class DecoupledEditorUI extends EditorUI {
/**
* Creates an instance of the editor UI class.
*
* @param {module:core/editor/editor~Editor} editor The editor instance.
* @param {module:ui/editorui/editoruiview~EditorUIView} view The view of the UI.
* @inheritDoc
*/
constructor( editor, view ) {
/**
* @inheritDoc
*/
this.editor = editor;

/**
* @inheritDoc
*/
this.view = view;

/**
* @inheritDoc
*/
this.componentFactory = new ComponentFactory( editor );

/**
* @inheritDoc
*/
this.focusTracker = new FocusTracker();
super( editor, view );

/**
* A normalized `config.toolbar` object.
Expand Down Expand Up @@ -80,11 +58,4 @@ export default class DecoupledEditorUI {
toolbar: this.view.toolbar
} );
}

/**
* Destroys the UI.
*/
destroy() {
this.view.destroy();
}
}
25 changes: 5 additions & 20 deletions tests/decouplededitorui.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,13 @@

/* globals document, Event */

import ComponentFactory from '@ckeditor/ckeditor5-ui/src/componentfactory';
import View from '@ckeditor/ckeditor5-ui/src/view';

import VirtualTestEditor from '@ckeditor/ckeditor5-core/tests/_utils/virtualtesteditor';
import DecoupledEditorUI from '../src/decouplededitorui';
import EditorUI from '@ckeditor/ckeditor5-core/src/editor/editorui';
import DecoupledEditorUIView from '../src/decouplededitoruiview';

import FocusTracker from '@ckeditor/ckeditor5-utils/src/focustracker';

import { keyCodes } from '@ckeditor/ckeditor5-utils/src/keyboard';
import testUtils from '@ckeditor/ckeditor5-core/tests/_utils/utils';
import utils from '@ckeditor/ckeditor5-utils/tests/_utils/utils';
Expand Down Expand Up @@ -41,20 +39,8 @@ describe( 'DecoupledEditorUI', () => {
} );

describe( 'constructor()', () => {
it( 'sets #editor', () => {
expect( ui.editor ).to.equal( editor );
} );

it( 'sets #view', () => {
expect( ui.view ).to.be.instanceOf( DecoupledEditorUIView );
} );

it( 'creates #componentFactory factory', () => {
expect( ui.componentFactory ).to.be.instanceOf( ComponentFactory );
} );

it( 'creates #focusTracker', () => {
expect( ui.focusTracker ).to.be.instanceOf( FocusTracker );
it( 'extends EditorUI', () => {
expect( ui ).to.instanceof( EditorUI );
} );
} );

Expand Down Expand Up @@ -166,13 +152,12 @@ describe( 'DecoupledEditorUI', () => {
} );

describe( 'destroy()', () => {
it( 'destroys the #view', () => {
const spy = sinon.spy( view, 'destroy' );
it( 'calls EditorUI#destroy', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as https://github.com/ckeditor/ckeditor5-editor-balloon/pull/21/files#r198513978.

const spy = testUtils.sinon.spy( EditorUI.prototype, 'destroy' );

return editor.destroy()
.then( () => {
sinon.assert.calledOnce( spy );
sinon.assert.calledWithExactly( spy );
} );
} );
} );
Expand Down