Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Fixed DocumentSelection#_fixGraveyardSelection #1047

Merged
merged 3 commits into from
Jul 25, 2017
Merged

Fixed DocumentSelection#_fixGraveyardSelection #1047

merged 3 commits into from
Jul 25, 2017

Conversation

scofalik
Copy link
Contributor

@scofalik scofalik commented Jul 25, 2017

Suggested merge commit message (convention)

Fixed: DocumentSelection#_fixGraveyardSelection now does not add incorrect range when all content is removed from document, instead it is empty. Closes ckeditor/ckeditor5#4129.

…correct range when all content is removed from document, instead it is empty.
@Reinmar
Copy link
Member

Reinmar commented Jul 25, 2017

Did you check all tests?

@scofalik
Copy link
Contributor Author

scofalik commented Jul 25, 2017

I've run npm t, though I might have out-dated other repos. Is something wrong?

It looks like the build that failed had passed all the tests:
Chrome 59.0.3071 (Linux 0.0.0): Executed 3484 of 3484 SUCCESS (13.338 secs / 8.377 secs)

@Reinmar
Copy link
Member

Reinmar commented Jul 25, 2017

Is something wrong?

IDK, I just asked because this is the kind of change which might've broken something.

@scofalik
Copy link
Contributor Author

scofalik commented Jul 25, 2017

I've run npm t and clicked a bit (but not much) in manual test.

I understand the fear, but when you think of it, the result will be for some scenarios the same, and for some clearly better, so I hope that the fix won't ruin something.

@Reinmar Reinmar merged commit 9f7e0a2 into master Jul 25, 2017
@Reinmar Reinmar deleted the t/1046 branch July 25, 2017 14:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DocumentSelection: fixed range ends up in incorrect place
2 participants