This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
T/1063: Introduce Selection#isEntireContentSelected( element )
#1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reinmar
reviewed
Aug 10, 2017
src/model/selection.js
Outdated
| @@ -625,6 +625,20 @@ export default class Selection { | |||
| } | |||
|
|
|||
| /** | |||
| * Checks whether the entire content in specified element is selected. | |||
There was a problem hiding this comment.
This description is not accurate. In such case, the <b>'s content is also fully selected:
<div>[x<b>y</b>z]</div>
It's hard to explain this in just one paragraph, but we should try with something like:
Checks whether the selection contains the entire content of the given element. This means that selection must start at a position {@link module:engine/model/position~Position#isTouching touching} the element's start and ends at position touching the element's end.
Reinmar
reviewed
Aug 10, 2017
src/model/selection.js
Outdated
| * @param {module:engine/model/element~Element} element | ||
| * @returns {Boolean} | ||
| */ | ||
| isEntireContentSelected( element ) { |
There was a problem hiding this comment.
This element should default to the root of the selection's root (this.anchor.root will be fine).
Reinmar
reviewed
Aug 10, 2017
| @@ -1237,4 +1237,56 @@ describe( 'Selection', () => { | |||
| } ); | |||
| } ); | |||
| } ); | |||
|
|
|||
| describe( 'isEntireContentSelected()', () => { | |||
There was a problem hiding this comment.
Missing tests:
- empty content,
- empty selection at a boundary of non-empty content
…er. Improved docs and tests.
|
I guess it's ready for review once again. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature: Added
Selection#isEntireContentSelected( element ). Closes ckeditor/ckeditor5#4137.