This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
T/ckeditor5 table/99: Selection post-fixer improvements. #1608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 7, 2018
scofalik
suggested changes
Dec 19, 2018
| @@ -159,6 +159,7 @@ function tryFixingCollapsedRange( range, schema ) { | |||
| // | |||
| // @param {module:engine/model/range~Range} range Expanded range to fix. | |||
| // @param {module:engine/model/schema~Schema} schema | |||
|
|
|||
| @@ -197,13 +202,23 @@ function tryFixingNonCollapsedRage( range, schema ) { | |||
| // At this point we eliminated valid positions on text nodes so if one of range positions is placed inside a limit element | |||
| // then the range crossed limit element boundaries and needs to be fixed. | |||
| if ( isStartInLimit || isEndInLimit ) { | |||
| const bothInSameParent = ( !!start.nodeAfter && !!end.nodeBefore ) && start.nodeAfter === end.nodeBefore; | |||
There was a problem hiding this comment.
Also, I am not sure if the name is correct. It's more that the selection is on the same element, isn't it?
There was a problem hiding this comment.
The name is correct but the check is not. Updated to look for parent check.
| let node = position.parent; | ||
| let parent = node; | ||
| // @returns {module:engine/model/node~Node} | ||
| function findOuterMostIsLimitAncestor( startingNode, schema ) { |
There was a problem hiding this comment.
I'd call it findOutermostLimitAncestor. The is part makes the name confusing. I know that we are looking for an object that passes isLimit() in Schema but still. Also AFAIR outermost is a one word.
| } | ||
|
|
||
| // Checks whether both range ends are placed around non-limit elements. | ||
| // Checks whether one of range ends is placed around non-limit elements. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Add selection post-fixer improvements. Closes ckeditor/ckeditor5#4444.
Additional information