Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Removed unnecessary HeadingCommand properties #79

Merged
merged 1 commit into from
Jun 8, 2017
Merged

Removed unnecessary HeadingCommand properties #79

merged 1 commit into from
Jun 8, 2017

Conversation

Reinmar
Copy link
Member

@Reinmar Reinmar commented Jun 8, 2017

Suggested merge commit message (convention)

Other: Removed HeadingCommand's properties which were exposed unnecessarily. Closes ckeditor/ckeditor5#2449.

BREAKING CHANGE: The HeadingCommand constructor's second parameter was changed from the options object to the modelElement alone.

NOTE: The HeadingOption interface was moved to the heading/heading module.

@Reinmar Reinmar requested a review from szymonkups June 8, 2017 09:07
@szymonkups szymonkups merged commit c80e691 into master Jun 8, 2017
@szymonkups szymonkups deleted the t/78 branch June 8, 2017 09:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The HeadingCommand class should care only about modelElement
2 participants