Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add confirmation check mark to the image upload animation #5147

Closed
pjasiun opened this issue May 8, 2018 · 5 comments · Fixed by ckeditor/ckeditor5-image#205
Closed

Add confirmation check mark to the image upload animation #5147

pjasiun opened this issue May 8, 2018 · 5 comments · Fixed by ckeditor/ckeditor5-image#205
Assignees
Labels
package:image type:improvement This issue reports a possible enhancement of an existing feature.
Milestone

Comments

@pjasiun
Copy link

pjasiun commented May 8, 2018

There should be ✅ when the upload finish sucessfully.

This is how it looks now in CKEditor 5:

before

This is how the animation looks like in Letters (with check mark):

after

Without it, upload looks incomplete.

@pjasiun
Copy link
Author

pjasiun commented May 8, 2018

BTW, apparently, there is something wrong with chack mark style, it is too small. It should be of course fixed.

@jodator
Copy link
Contributor

jodator commented May 9, 2018

One comment: I've totally missed that check mark while watching the animation for the first time. Wouldn't be better to put it on the left side of an image?

@dkonopka
Copy link
Contributor

dkonopka commented May 10, 2018

IMHO loader bar is appearing from the left to the right and this is the proper direction which the user eyes should follow.

cc @oleq

@jodator
Copy link
Contributor

jodator commented May 10, 2018

IMHO loader bar is appearing from the left to the right and this is the proper direction which user eyes should follow.

Maybe the bar also should be a bit bigger as it's also easy to miss - upload is very fast on your gifs.

Anyway I think that you guys now the best here, I've just dropping my 2¢ ;)

@pjasiun
Copy link
Author

pjasiun commented May 14, 2018

Keep in mind that the reason for this tickets is to unify upload UI in Letters and CKE 5, not to redesign it. If, by the way, you can make it better easily it would be great, but I remember we had a really long talk about the thickness of the bar, animation, etc and I don't want to reopen this discussion here. If you find something wrong in the upload UI feel free to report a separate ticket about it.

pjasiun referenced this issue in ckeditor/ckeditor5-image May 18, 2018
Feature: Added upload complete icon. Closes #204.
pjasiun referenced this issue in ckeditor/ckeditor5-theme-lark May 18, 2018
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-image Oct 9, 2019
@mlewand mlewand added this to the iteration 18 milestone Oct 9, 2019
@mlewand mlewand added module:ux type:improvement This issue reports a possible enhancement of an existing feature. package:image labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:image type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants