This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
T/245: The "imageInsert" command #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reinmar
suggested changes
Nov 19, 2018
There was a problem hiding this comment.
Misses changes in features/image.md. The new command should be mentioned there. Also, please update docs of uploadImage because it can accept multiple files. It'd be good too to have examples of these two commands usage in their respective class descriptions.
|
@Reinmar - I think it's done. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature: Introduce the "imageInsert" command. Closes ckeditor/ckeditor5#5171. Closes ckeditor/ckeditor5#5174.
BREAKING CHANGE: The
'imageUpload'commandfilesparameter was renamed tofile.Additional information