Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

T/ckeditor5/1341: Prevent memory leaks #270

Merged
merged 2 commits into from
Jan 22, 2019
Merged

T/ckeditor5/1341: Prevent memory leaks #270

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
780da66
Prevent memory leaks of UI components.
jodator Jan 14, 2019
0731273
Merge branch 'master' into t/ckeditor5/1341
jodator Jan 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/imagetextalternative/imagetextalternativeui.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,16 @@ export default class ImageTextAlternativeUI extends Plugin {
this._createForm();
}

/**
* @inheritDoc
*/
destroy() {
super.destroy();

// Destroy created UI components as they are not automatically destroyed (see ckeditor5#1341).
this._form.destroy();
}

/**
* Creates a button showing the balloon panel for changing the image text alternative and
* registers it in the editor {@link module:ui/componentfactory~ComponentFactory ComponentFactory}.
Expand Down