Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Make Clipboard plugin required by ImageUploadEditing. #326

Merged
merged 3 commits into from
Sep 3, 2019

Conversation

jodator
Copy link
Contributor

@jodator jodator commented Sep 2, 2019

Suggested merge commit message (convention)

Other: Make Clipboard plugin required dependency of ImageUploadEding. Closes ckeditor/ckeditor5#2910.


Additional information

  • This is the only required fix I've found for 'soft' requires in CKEditor5 code base.
  • ps.: I didn't add the BREAKING CHANGE: entry as I don't see this a breaking change but might be needed from a puristic POV:
BREAKING CHANGE: The ImageUploadEding now requires Clipboard plugin to work.
  • also the BallonToolbar usage is OK:

About that BalloonToolbar plugin use - it is OK. It is not a plugin but a class of and BalloonEditor which always requires BalloonToolbar.

@jodator jodator requested a review from Reinmar September 2, 2019 14:38
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0009%) to 99.704% when pulling daf0741 on t/ckeditor5-core/193 into 2cfe305 on master.

Copy link
Member

@Reinmar Reinmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some issue with coverage.

@jodator
Copy link
Contributor Author

jodator commented Sep 3, 2019

It is because of number of lines have decreased and we still didn't fix coverage here.

@Reinmar Reinmar merged commit 311c48c into master Sep 3, 2019
@Reinmar Reinmar deleted the t/ckeditor5-core/193 branch September 3, 2019 09:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get rid of soft requirements
3 participants