This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Moved ImageBalloonPanelView focus tracking to init() method #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing to extend its template.
szymonkups
changed the title
Reinmar
reviewed
Feb 6, 2017
src/ui/imageballoonpanelview.js
Outdated
| * @inheritDoc | ||
| */ | ||
| init() { | ||
| super.init(); |
There was a problem hiding this comment.
This may return a promise. Switch the order of calls in this function and return the result of super.init() – that'd be the easiest solution. And remember to write a test that a promise is returned ;)
There was a problem hiding this comment.
PS. I wouldn't require that if BalloonPanelView was from this package. But it's a separate package so it can change independently.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed merge commit message
Fix: Moved focus tracking setup in
ImageBalloonPanelViewtoinit()method. Closes ckeditor/ckeditor5#5060.