Merge pull request #168 from ckeditor/t/ckeditor5-engine/1295

Other: Aligning with new conversion helpers API.
ckeditor · Feb 19, 2018 · 592d38c · 592d38c
2 parents 6df4c55 + 0dade11
commit 592d38c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/src/linkengine.js b/src/linkengine.js
@@ -31,10 +31,8 @@ export default class LinkEngine extends Plugin {
 		// Allow link attribute on all inline nodes.
 		editor.model.schema.extend( '$text', { allowAttributes: 'linkHref' } );
 
-		const linkElementCreator = ( href, data, consumable, api ) => createLinkElement( href, api.writer );
-
 		editor.conversion.for( 'downcast' )
-			.add( downcastAttributeToElement( 'linkHref', { view: linkElementCreator } ) );
+			.add( downcastAttributeToElement( { model: 'linkHref', view: createLinkElement } ) );
 
 		editor.conversion.for( 'upcast' )
 			.add( upcastElementToAttribute( {

diff --git a/tests/linkengine.js b/tests/linkengine.js
@@ -110,7 +110,7 @@ describe( 'LinkEngine', () => {
 		it( 'should should set priority for `linkHref` higher than all other attribute elements', () => {
 			model.schema.extend( '$text', { allowAttributes: 'foo' } );
 
-			editor.conversion.for( 'downcast' ).add( downcastAttributeToElement( 'foo', { view: 'f' } ) );
+			editor.conversion.for( 'downcast' ).add( downcastAttributeToElement( { model: 'foo', view: 'f' } ) );
 
 			setModelData( model,
 				'<paragraph>' +