Removed the confirmation of mention selection by using the space and …

…tab keys.
ckeditor · Mar 9, 2020 · 9d4b261 · 9d4b261
1 parent dd41b3e
commit 9d4b261
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 15 deletions.
diff --git a/src/mentionui.js b/src/mentionui.js
@@ -33,8 +33,6 @@ const handledKeyCodes = [
 	keyCodes.arrowup,
 	keyCodes.arrowdown,
 	keyCodes.enter,
-	keyCodes.tab,
-	keyCodes.space,
 	keyCodes.esc
 ];
 
@@ -121,7 +119,7 @@ export default class MentionUI extends Plugin {
 					this._mentionsView.selectPrevious();
 				}
 
-				if ( data.keyCode == keyCodes.enter || data.keyCode == keyCodes.tab || data.keyCode == keyCodes.space ) {
+				if ( data.keyCode == keyCodes.enter ) {
 					this._mentionsView.executeSelected();
 				}
 

diff --git a/tests/mentionui.js b/tests/mentionui.js
@@ -1566,10 +1566,6 @@ describe( 'MentionUI', () => {
 
 			describe( 'on "execute" keys', () => {
 				testExecuteKey( 'enter', keyCodes.enter, feedItems );
-
-				testExecuteKey( 'tab', keyCodes.tab, feedItems );
-
-				testExecuteKey( 'space', keyCodes.space, feedItems );
 			} );
 		} );
 
@@ -1718,10 +1714,6 @@ describe( 'MentionUI', () => {
 
 				describe( 'on "execute" keys', () => {
 					testExecuteKey( 'enter', keyCodes.enter, issues );
-
-					testExecuteKey( 'tab', keyCodes.tab, issues );
-
-					testExecuteKey( 'space', keyCodes.space, issues );
 				} );
 			} );
 		} );
@@ -1843,10 +1835,6 @@ describe( 'MentionUI', () => {
 
 				describe( 'on "execute" keys', () => {
 					testExecuteKey( 'enter', keyCodes.enter, issues );
-
-					testExecuteKey( 'tab', keyCodes.tab, issues );
-
-					testExecuteKey( 'space', keyCodes.space, issues );
 				} );
 
 				describe( 'mouse', () => {