Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Commit

Permalink
Merge pull request #165 from ckeditor/t/ckeditor5-widget/66
Browse files Browse the repository at this point in the history
Internal: Renamed the .ck-widget_selectable class to .ck-widget_with-selection-handler for better semantics (see ckeditor/ckeditor5-widget#66).
  • Loading branch information
dkonopka authored Jan 17, 2019
2 parents e3a5c09 + 681e078 commit 15fc1f7
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
3 changes: 2 additions & 1 deletion tests/_utils/utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,8 @@ export function viewTable( tableData, attributes = {} ) {
asWidget
} ) }</tbody>` : '';

const figureAttributes = asWidget ? 'class="ck-widget ck-widget_selectable table" contenteditable="false"' : 'class="table"';
const figureAttributes = asWidget ?
'class="ck-widget ck-widget_with-selection-handler table" contenteditable="false"' : 'class="table"';
const widgetHandler = '<div class="ck ck-widget__selection-handler"></div>';

return `<figure ${ figureAttributes }>${ asWidget ? widgetHandler : '' }<table>${ thead }${ tbody }</table></figure>`;
Expand Down
10 changes: 5 additions & 5 deletions tests/converters/downcast.js
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ describe( 'downcast converters', () => {
setModelData( model, modelTable( [ [ '' ] ] ) );

expect( formatTable( getViewData( viewDocument, { withoutSelection: true } ) ) ).to.equal( formatTable(
'<figure class="ck-widget ck-widget_selectable table" contenteditable="false">' +
'<figure class="ck-widget ck-widget_with-selection-handler table" contenteditable="false">' +
'<div class="ck ck-widget__selection-handler"></div>' +
'<table>' +
'<tbody>' +
Expand Down Expand Up @@ -537,7 +537,7 @@ describe( 'downcast converters', () => {

expect( formatTable(
getViewData( viewDocument, { withoutSelection: true } ) ) ).to.equal( formatTable(
'<figure class="ck-widget ck-widget_selectable table" contenteditable="false">' +
'<figure class="ck-widget ck-widget_with-selection-handler table" contenteditable="false">' +
'<div class="ck ck-widget__selection-handler"></div>' +
'<table>' +
'<tbody>' +
Expand Down Expand Up @@ -683,7 +683,7 @@ describe( 'downcast converters', () => {
} );

expect( formatTable( getViewData( viewDocument, { withoutSelection: true } ) ) ).to.equal( formatTable(
'<figure class="ck-widget ck-widget_selectable table" contenteditable="false">' +
'<figure class="ck-widget ck-widget_with-selection-handler table" contenteditable="false">' +
'<div class="ck ck-widget__selection-handler"></div>' +
'<table>' +
'<tbody>' +
Expand Down Expand Up @@ -860,7 +860,7 @@ describe( 'downcast converters', () => {
} );

expect( formatTable( getViewData( viewDocument, { withoutSelection: true } ) ) ).to.equal( formatTable(
'<figure class="ck-widget ck-widget_selectable table" contenteditable="false">' +
'<figure class="ck-widget ck-widget_with-selection-handler table" contenteditable="false">' +
'<div class="ck ck-widget__selection-handler"></div>' +
'<table>' +
'<thead>' +
Expand Down Expand Up @@ -1074,7 +1074,7 @@ describe( 'downcast converters', () => {
} );

expect( formatTable( getViewData( viewDocument, { withoutSelection: true } ) ) ).to.equal( formatTable(
'<figure class="ck-widget ck-widget_selectable table" contenteditable="false">' +
'<figure class="ck-widget ck-widget_with-selection-handler table" contenteditable="false">' +
'<div class="ck ck-widget__selection-handler"></div>' +
'<table>' +
'<tbody>' +
Expand Down

0 comments on commit 15fc1f7

Please sign in to comment.