This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
t/138: Changed the labels of the insert column buttons for better UX and translatability #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o insertTableColumnLeft and insertTableColumnRight.
…column left' and 'Insert column after'->'Insert column right'.
ma2ciek
reviewed
Oct 30, 2018
| commandName: 'insertTableColumnBefore', | ||
| label: t( 'Insert column before' ) | ||
| commandName: 'insertTableColumnLeft', | ||
| label: t( 'Insert column left' ) |
There was a problem hiding this comment.
I'm thinking about Insert column to the left, longer, but more accurate.
There was a problem hiding this comment.
That's a tricky topic. I've seen "Insert left" and "Insert column to the left" in different MS Word versions. GDocs uses simple "Insert column left". @AnnaTomanek?
|
Please ping me when you'll merge it. I need to push that to Transifex so we get those strings translated before the release. |
|
We've agreed on this with @oleq that he will try to push these translations and do not break much of existing ones 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Changed the labels of the insert column buttons for better UX and translatability. Closes ckeditor/ckeditor5#3245.
BREAKING CHANGE: The
insertTableColumnBeforecommand has been renamed toinsertTableColumnLeft.BREAKING CHANGE: The
insertTableColumnAftercommand has been renamed toinsertTableColumnRight.BREAKING CHANGE: The valid values of the
orderoption of theInsertColumnCommandconstructor have changed.Additional information
Requires executing Transifex commands after merge.