This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Truncating table selection handler #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d as first child in the content.
|
LGTM 👏 @Mgsy Can you take an unbiased look at this PR? |
|
LGTM 👌 |
dkonopka
added a commit
that referenced
this pull request
Jan 17, 2019
Internal: Renamed the .ck-widget_selectable class to .ck-widget_with-selection-handler for better semantics. Made the selection handler crop fix introduced in #214 generic for all widgets (see ckeditor/ckeditor5-widget#66).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix: Table selection handler should not be truncated if it is a first-child in the block quote or the content. Closes https://github.com/ckeditor/ckeditor5-block-quote/issues/28.
Additional information
Check table inside table case - fiddlejs demo
I've checked it on Edge and actually
calc()with CSS Variables works fine (even addingemto thepx!)