This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Moved .ck-progress-bar outside .ck-content and removed obsolete CSS variables
#240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleq
added a commit
to ckeditor/ckeditor5-image
that referenced
this pull request
Jul 31, 2019
Other: Removed the obsolete `--ck-color-upload-infinite-background` CSS custom property. See ckeditor/ckeditor5-theme-lark#240.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other:
.ck-progress-barstyles should not be related with.ck-content. Additionaly removed two unused variables--ck-color-upload-infinite-backgroundand--ck-image-upload-progress-line-width. See https://github.com/ckeditor/ckeditor5-theme-lark/issues/239.Closes https://github.com/ckeditor/ckeditor5-theme-lark/issues/239.
Closes ckeditor/ckeditor5#1915.
Additional information
Related PR ckeditor/ckeditor5-image#301
I've removed obsolete variables related to the old infinite loader designed for the collaboration purposes. At this moment we are using a centred spinner instead of it.