Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

t/344: Refactoring of the dropdown ecosystem #361

Merged
merged 79 commits into from
Feb 8, 2018
Merged

t/344: Refactoring of the dropdown ecosystem #361

merged 79 commits into from
Feb 8, 2018

Commits on Feb 2, 2018

  1. Other: Initial SplitButton implementation.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    cdbc350 View commit details
    Browse the repository at this point in the history

  2. Other: Update SplitButtonDropdown keystrokes behavior.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    7de6eb4 View commit details
    Browse the repository at this point in the history

  3. Other: Make createSplitButtonDropdown minimal.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    3e62922 View commit details
    Browse the repository at this point in the history

  4. Other: Change how split button is bound to model.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    537fbe6 View commit details
    Browse the repository at this point in the history

  5. Other: Move some SplitButtonDropdown functionality to SplitButtonDrop… 

    …down.
    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    f4fe2e8 View commit details
    Browse the repository at this point in the history

  6. Other: Update SplitButton CSS.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    7804863 View commit details
    Browse the repository at this point in the history

  7. Other: Fix SplitButton CSS.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    575b2a9 View commit details
    Browse the repository at this point in the history

  8. Change: Horizontal toolbar should have nowrap set.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    488d050 View commit details
    Browse the repository at this point in the history

  9. Changed: Make split button in toolbar look like other buttons.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    4a291b9 View commit details
    Browse the repository at this point in the history

  10. Added: Style toolbar separator in button dropdown.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    08fa387 View commit details
    Browse the repository at this point in the history

  11. Fix: Split button's main button outline is not displayed correctly.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    2c96b24 View commit details
    Browse the repository at this point in the history

  12. Other: SplitButton dropdown improvements.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    dbc7a70 View commit details
    Browse the repository at this point in the history

  13. Remove splitbuttondropdownview.js and use 'select' button event instead.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    0394490 View commit details
    Browse the repository at this point in the history

  14. Changed: Stub new dropdown creator methods.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    e1cc15c View commit details
    Browse the repository at this point in the history

  15. Changed: Extract common dropdown tasks to helper methods.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    102e5c7 View commit details
    Browse the repository at this point in the history

  16. Changed: Temporary disable 'isOn' binding in button.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    ba2a0ee View commit details
    Browse the repository at this point in the history

  17. Changed: Rename parts of SplitButton buttons to action/select.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    79ec879 View commit details
    Browse the repository at this point in the history

  18. Fix: typos.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    63642cf View commit details
    Browse the repository at this point in the history

  19. Changed: Remove crateButtonDropdown() and createListDropdown() helpers.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    b70ffca View commit details
    Browse the repository at this point in the history

  20. Tests: add tests for dropdown util: enableModelIfOneIsEnabled().

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    80c7258 View commit details
    Browse the repository at this point in the history

  21. Changed: Remove createDropdown() method.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    5cf51a5 View commit details
    Browse the repository at this point in the history

  22. Changed: Remove toolbar class binding from dropdown.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    9236088 View commit details
    Browse the repository at this point in the history

  23. Changed: Rename button dropdown to toolbar dropdown.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    16f14ed View commit details
    Browse the repository at this point in the history

  24. Tests: Add tests for createSplitButtonForDropdown() and createButtonF… 

    …orDropdown().
    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    7bf2edb View commit details
    Browse the repository at this point in the history

  25. Changed: Removed addDefaultBehavior() from dropdown utils.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    53a9fdc View commit details
    Browse the repository at this point in the history

  26. Changed: Removed createSingleButtonDropdown() from dropdown utils.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    a8b8f2f View commit details
    Browse the repository at this point in the history

  27. Changed: Removed createSplitButtonDropdown() from dropdown utils.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    0d33dc2 View commit details
    Browse the repository at this point in the history

  28. Tests: Fix test after recent changes.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    481630c View commit details
    Browse the repository at this point in the history

  29. Other: Extract focusDropdownContentsOnArrows() to own file.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    67251f9 View commit details
    Browse the repository at this point in the history

  30. Other: Extract closeDropdownOnExecute() to own file.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    ba41ff8 View commit details
    Browse the repository at this point in the history

  31. Other: Extract closeDropdownOnBlur() to own file.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    7b109be View commit details
    Browse the repository at this point in the history

  32. Other: Extract createButtonForDropdown() to own file.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    aee02ee View commit details
    Browse the repository at this point in the history

  33. Other: Extract createSplitButtonForDropdown() to own file.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    420de05 View commit details
    Browse the repository at this point in the history

  34. Other: Extract createDropdownView() to own file.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    b787981 View commit details
    Browse the repository at this point in the history

  35. Other: Extract enableModelIfOneIsEnabled() to own file.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    d03791a View commit details
    Browse the repository at this point in the history

  36. Other: Extract addListViewToDropdown() to own file.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    1b93679 View commit details
    Browse the repository at this point in the history

  37. Other: Extract addToolbarToDropdown() to own file.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    88217ed View commit details
    Browse the repository at this point in the history

  38. Other: Extract getBindingTargets() to own file and move it to ui/bi… 

    …ndings.
    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    4ee81bf View commit details
    Browse the repository at this point in the history

  39. Fix: Updated toolbardropdown.css path.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    b39b544 View commit details
    Browse the repository at this point in the history

  40. Other: Revert icon hack from ButtonView.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    358c022 View commit details
    Browse the repository at this point in the history

  41. Fixed: Toolbar dropdown's items "execute" event is not delegated to d… 

    …ropdown.
    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    335e5cb View commit details
    Browse the repository at this point in the history

  42. Tests: Remove empty describe() from addtoolbartodropdown tests.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    3d21766 View commit details
    Browse the repository at this point in the history

  43. Tests: Add SplitButtonView tests.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    26d94b6 View commit details
    Browse the repository at this point in the history

  44. Tests: Add DropdownPanelView#focus() and `DropdownPanelView#focusLa… 

    …st()` tests.
    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    e942460 View commit details
    Browse the repository at this point in the history

  45. Docs: Add dropdowns framework guide stub.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    f446a4a View commit details
    Browse the repository at this point in the history

  46. Changed: Change how dropdowns with ButtonView and SplitButtonView… 

    … are created.
    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    acca5f4 View commit details
    Browse the repository at this point in the history

  47. Changed: Remove dafult dropdown behavior helper methods from API.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    2e2815f View commit details
    Browse the repository at this point in the history

  48. Added: Introduce bindOneToMany() binding helper.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    30e1e9b View commit details
    Browse the repository at this point in the history

  49. Changed: Move addToolbarToDropdown() helper to ui/dropdown/utils.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    bcd04c5 View commit details
    Browse the repository at this point in the history

  50. Changed: Move addListViewToDropdown() helper to ui/dropdown/utils.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    2e7ab21 View commit details
    Browse the repository at this point in the history

  51. Changed: Bind dropdown behavior to DropdownView instead of Model.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    fec44e7 View commit details
    Browse the repository at this point in the history

  52. Docs: Updated dropdown framework guide.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    82b46f3 View commit details
    Browse the repository at this point in the history

  53. Fix: Wrong path to ckeditor5-utils package in tests.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    a0e8743 View commit details
    Browse the repository at this point in the history

  54. Code style: The dots are required at the end of the comment.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    e5251ed View commit details
    Browse the repository at this point in the history

  55. Docs: Update SplitButtonView documentation.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    e3139aa View commit details
    Browse the repository at this point in the history

  56. Changed: Use bind().toMany() binding chain from ObservableMixin.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    8161c10 View commit details
    Browse the repository at this point in the history

  57. Docs: Brought dropdown/utils methods to a common naming scheme.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    23e0d16 View commit details
    Browse the repository at this point in the history

  58. Changed: Review SplitButton#actionView bindings.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    093e735 View commit details
    Browse the repository at this point in the history

  59. Changed: Removed unnecessary private method from dropdown/utils.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    2264fcf View commit details
    Browse the repository at this point in the history

  60. Docs: Document optional observable properties of the DropdownView.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    caefc2c View commit details
    Browse the repository at this point in the history

  61. Docs: Fix links in documentation and update dropdown's properties.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    2841422 View commit details
    Browse the repository at this point in the history

  62. Docs: Fix code block padding in utils.js.

    @jodator
    jodator committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    383524c View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2018

  1. Changed: Extract DropdownButtonView from Dropdown.

    @jodator
    jodator committed Feb 5, 2018
    Configuration menu
    Copy the full SHA
    39449f7 View commit details
    Browse the repository at this point in the history

  2. Changed: Move dropdown buttons to ui/dropdown/buttons.

    @jodator
    jodator committed Feb 5, 2018
    Configuration menu
    Copy the full SHA
    f1beae8 View commit details
    Browse the repository at this point in the history

  3. Changed: Make ButtonClass as a parameter of createDropdown().

    @jodator
    jodator committed Feb 5, 2018
    Configuration menu
    Copy the full SHA
    b071836 View commit details
    Browse the repository at this point in the history

  4. Docs: Updated the dropdown framework guide stub.

    @jodator
    jodator committed Feb 5, 2018
    Configuration menu
    Copy the full SHA
    f92a96b View commit details
    Browse the repository at this point in the history

  5. Code style: Fix code indentation in code examples.

    @jodator
    jodator committed Feb 5, 2018
    Configuration menu
    Copy the full SHA
    3e0d7a8 View commit details
    Browse the repository at this point in the history

  6. Changed: Remove dropdown.buttonView bindings to dropdown.

    @jodator
    jodator committed Feb 5, 2018
    Configuration menu
    Copy the full SHA
    6a08edc View commit details
    Browse the repository at this point in the history

  7. Docs: Move dropdowns framework guide to architecture/ui-library guide.

    @jodator
    jodator committed Feb 5, 2018
    Configuration menu
    Copy the full SHA
    33783eb View commit details
    Browse the repository at this point in the history

  8. Docs: Introduce ButtonInterface and DropdownButtonInterface.

    @jodator
    jodator committed Feb 5, 2018
    Configuration menu
    Copy the full SHA
    a0308c3 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2018

  1. Docs: Update dropdown buttons documentation.

    @jodator
    jodator committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    1413c2e View commit details
    Browse the repository at this point in the history

  2. Docs: Update dropdown documentation.

    @jodator
    jodator committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    41e1bbe View commit details
    Browse the repository at this point in the history

  3. Docs: Add missing docs for DropdownPanelView.

    @jodator
    jodator committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    2b0291d View commit details
    Browse the repository at this point in the history

  4. Changed: Rename DropdownButtonInterface#select event to #open.

    @jodator
    jodator committed Feb 6, 2018
    Configuration menu
    Copy the full SHA
    8344775 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2018

  1. Merge branch 'master' into t/344

    @Reinmar
    Reinmar committed Feb 7, 2018
    Configuration menu
    Copy the full SHA
    faa800b View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2018

  1. Improved ButtonInterface and how other classes implement it.

    @Reinmar
    Reinmar committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    110f4f8 View commit details
    Browse the repository at this point in the history

  2. Improved docs.

    @Reinmar
    Reinmar committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    a908e03 View commit details
    Browse the repository at this point in the history

  3. Tests: Update dropdown manual tests.

    @jodator
    jodator committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    07925bb View commit details
    Browse the repository at this point in the history

  4. Avoid using the word Interface in interface names by simply stripping… 

    … it.
    @Reinmar
    Reinmar committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    7c0e6c9 View commit details
    Browse the repository at this point in the history