Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Fix: Fixed View#render collision when moving focus from a one editable to the other in multi-root editor #477

Merged
merged 2 commits into from
Apr 5, 2019

Conversation

oskarwrobel
Copy link
Contributor

Suggested merge commit message (convention)

Fix: Fixed View#render collision when moving focus from a one editable to the other in multi-root editor. Closes ckeditor/ckeditor5#1676.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@oskarwrobel oskarwrobel requested a review from pjasiun April 4, 2019 15:59
@pjasiun pjasiun requested a review from Mgsy April 5, 2019 07:31
@pjasiun pjasiun merged commit 17e86f9 into master Apr 5, 2019
@pjasiun pjasiun deleted the t/ckeditor5/1676 branch April 5, 2019 07:49
@Reinmar
Copy link
Member

Reinmar commented Apr 5, 2019

Pity that you modified an existing test case. Unless it was bad, it'd make sense to have two here.

@oskarwrobel
Copy link
Contributor Author

I created two tests first. But the second one included the first one so there was no point to keep it separately.

@Reinmar
Copy link
Member

Reinmar commented Apr 5, 2019

I don't buy it 😜 There could be two tests as long as they do something a bit different, and focus on bit different scenarios, even if today they boil down to the same thing, in the future they may bo covering different things.

@oskarwrobel
Copy link
Contributor Author

oskarwrobel commented Apr 5, 2019

It's not a different scenario. It's the same scenario (toggling class on editable) but the test was not good enough to find a bug. Now it is.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants