-
Notifications
You must be signed in to change notification settings - Fork 18
t/ckeditor5/416d: Implemented automatic items grouping in the ToolbarView component #523
Conversation
… editor UX in narrow viewports.
Some concerns:
|
…he #element has a proper class.
@Mgsy Could you check the constellation and play with the new feature a little bit? There's a manual test ready but also all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor things detected. I couldn't find anything in particular that should needed to be changed. The code looks OK.
I also find some minor issues with the behavior but nothing blocking though (maybe except that execute on overflowed toolbar).
Yes.
Never planned this but this is definitely a feature 😛
It's a general issue. I added a comment explaining the scope of the problem.
Yup. Created a follow-up. |
Co-Authored-By: Maciej <jodator@jodator.net>
Suggested merge commit message (convention)
Feature: Implemented automatic items grouping in the
ToolbarView
component. Closes ckeditor/ckeditor5#416.BREAKING CHANGE: The internal structure of the component has changed. Toolbar items are no longer direct descendants of the toolbar in DOM, which may affect some integrations (mainly CSS selectors if adjustments were made to the styles).
Additional information
Requires:
getResizeObserver()
helper ckeditor5-utils#303 (resize observer API)Constellation for testing and development.