i/6049: Created the LabeledView class #537

oleq · 2020-01-21T17:11:24Z

Feature: Created the LabeledView class (see ckeditor/ckeditor5-table#227).

Also added id properties to the DropdownView and LabelView for compatibility with the LabeledView.

coveralls · 2020-01-24T14:58:20Z

Coverage remained the same at 100.0% when pulling 19a6af1 on i/6049 into 6b3c558 on master.

jodator

I've found two minor things to clean up.

src/labeledview/utils.js

tests/labeledview/utils.js

oleq added 8 commits January 14, 2020 16:44

Brought LabeledView. Aligned DropdownView to LabeledView interface.

23a592d

Added styles for LabeledView.

b0a231c

Docs: LabeledView docs.

2154013

Tests: Added tests for DropdownView#id.

67881ca

Tests: Added tests for LabelView#id.

dd21b0a

Tests: Added tests for the LabeledView class.

4fe1d81

Tests: Added tests for LabeledView utils. Added some docs.

2fb6bd8

Aligned BoxedEditorUIView to the new LabelView API.

af88744

oleq added the pr:sub label Jan 21, 2020

oleq mentioned this pull request Jan 21, 2020

I/6049: Introduced the table cell properties UI ckeditor/ckeditor5-table#227

Merged

oleq and others added 3 commits January 21, 2020 18:14

Code clean-up.

0fb4369

Docs: Fixed a broken link.

2df2c17

Fix invalid self imports.

6c941f7

Remove empty afterEach() from labeled input view utils tests.

17b940b

jodator approved these changes Jan 24, 2020

View reviewed changes

src/labeledview/utils.js Outdated Show resolved Hide resolved

tests/labeledview/utils.js Outdated Show resolved Hide resolved

Update src/labeledview/utils.js

19a6af1

jodator merged commit ec39406 into master Jan 24, 2020

jodator deleted the i/6049 branch January 24, 2020 15:55

Provide feedback